From 25f7d35e03fe2006cf21de6cdda999ea0e03053e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ullrich=20Sch=C3=A4fer?= <hi+github@ullrich.is>
Date: Sat, 23 May 2026 10:49:18 +0200
Subject: [PATCH] Fix E2E: associate labels with inputs via htmlFor/id;
 increase test timeouts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 apps/journal/app/routes/settings.connections.komoot.tsx | 9 ++++++---
 e2e/komoot-import.test.ts                               | 4 ++++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/apps/journal/app/routes/settings.connections.komoot.tsx b/apps/journal/app/routes/settings.connections.komoot.tsx
index 3b3d2f3..611bb32 100644
--- a/apps/journal/app/routes/settings.connections.komoot.tsx
+++ b/apps/journal/app/routes/settings.connections.komoot.tsx
@@ -119,10 +119,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
         </div>
         <form onSubmit={handleVerify} className="mt-4 flex flex-col gap-3 sm:flex-row sm:items-end">
           <div className="flex-1">
-            <label className="block text-sm font-medium text-gray-700">
+            <label htmlFor="komoot-profile-url" className="block text-sm font-medium text-gray-700">
               {t("komoot.profileUrlLabel")}
             </label>
             <input
+              id="komoot-profile-url"
               type="text"
               value={komootProfileUrl}
               onChange={(e) => setKomootProfileUrl(e.target.value)}
@@ -158,10 +159,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
         <h3 className="font-medium text-gray-900">{t("komoot.authenticatedSection")}</h3>
         <form onSubmit={handleConnect} className="mt-4 flex flex-col gap-3">
           <div>
-            <label className="block text-sm font-medium text-gray-700">
+            <label htmlFor="komoot-email" className="block text-sm font-medium text-gray-700">
               {t("komoot.emailLabel")}
             </label>
             <input
+              id="komoot-email"
               type="email"
               value={email}
               onChange={(e) => setEmail(e.target.value)}
@@ -171,10 +173,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
             />
           </div>
           <div>
-            <label className="block text-sm font-medium text-gray-700">
+            <label htmlFor="komoot-password" className="block text-sm font-medium text-gray-700">
               {t("komoot.passwordLabel")}
             </label>
             <input
+              id="komoot-password"
               type="password"
               value={password}
               onChange={(e) => setPassword(e.target.value)}
diff --git a/e2e/komoot-import.test.ts b/e2e/komoot-import.test.ts
index 54cc70f..3cee685 100644
--- a/e2e/komoot-import.test.ts
+++ b/e2e/komoot-import.test.ts
@@ -123,6 +123,8 @@ function mockKomootGpx(page: Page, tourId: string) {
 }
 
 test.describe("Komoot connection page", () => {
+  test.setTimeout(60000);
+
   test("unauthenticated user is redirected to login", async ({ page }) => {
     await page.goto("/settings/connections/komoot");
     await expect(page).toHaveURL(/\/auth\/login/, { timeout: 5000 });
@@ -207,6 +209,8 @@ test.describe("Komoot connection page", () => {
 });
 
 test.describe("Komoot import page", () => {
+  test.setTimeout(90000);
+
   test("shows importable public tours after public verify", async ({ page }) => {
     const cdp = await page.context().newCDPSession(page);
     const authenticatorId = await setupVirtualAuthenticator(cdp);