trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: recompute route on profile change

Browse source 
Added Y.Map observer on routeData that triggers route recomputation
when the 'profile' key changes. Previously profile changes synced
via Yjs but didn't trigger a new BRouter request.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-03-23 00:58:31 +01:00
parent 54b6232c5d
commit 49e9d589b1
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
1 changed files with 31 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

35
apps/planner/app/lib/use-routing.ts
View file

@ -1,4 +1,5 @@
import { useCallback, useEffect, useRef, useState } from "react";
import * as Y from "yjs";
import type { YjsState } from "./use-yjs";
interface RouteStats {
@ -12,6 +13,13 @@ interface WaypointData {
lon: number;
}
function getWaypointsFromYjs(waypoints: Y.Array<Y.Map<unknown>>): WaypointData[] {
return waypoints.toArray().map((yMap) => ({
lat: yMap.get("lat") as number,
lon: yMap.get("lon") as number,
}));
}
export function useRouting(yjs: YjsState | null) {
const [isHost, setIsHost] = useState(false);
const [computing, setComputing] = useState(false);
@ -26,7 +34,6 @@ export function useRouting(yjs: YjsState | null) {
const states = yjs.awareness.getStates();
const localId = yjs.awareness.clientID;
// Find the client with the lowest ID (longest connected approximation)
let lowestId = Infinity;
states.forEach((_state, clientId) => {
if (clientId < lowestId) lowestId = clientId;
@ -64,7 +71,6 @@ export function useRouting(yjs: YjsState | null) {
const geojson = await response.json();
// Extract stats from BRouter response
const props = geojson.features?.[0]?.properties;
if (props) {
setRouteStats({
@ -76,10 +82,9 @@ export function useRouting(yjs: YjsState | null) {
});
}
// Store route in Yjs for all participants
yjs.routeData.set("geojson", JSON.stringify(geojson));
} catch {
// Route computation failed — don't crash
// Route computation failed
} finally {
setComputing(false);
}
@ -96,5 +101,27 @@ export function useRouting(yjs: YjsState | null) {
[isHost, computeRoute],
);
// Watch for profile changes and trigger recompute
useEffect(() => {
if (!yjs || !isHost) return;
const onProfileChange = () => {
const wps = getWaypointsFromYjs(yjs.waypoints);
if (wps.length >= 2) {
requestRoute(wps);
}
};
// Observe routeData for profile changes
const observer = (event: Y.YMapEvent<unknown>) => {
if (event.keysChanged.has("profile")) {
onProfileChange();
}
};
yjs.routeData.observe(observer);
return () => yjs.routeData.unobserve(observer);
}, [yjs, isHost, requestRoute]);
return { isHost, computing, routeStats, requestRoute };
}