trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge remote-tracking branch 'refs/remotes/origin/main' into copilot/identify-spec-implementation-drift

Browse source 
# Conflicts:
#	apps/planner/app/components/PlannerMap.tsx
#	apps/planner/app/lib/brouter.ts
#	openspec/specs/no-go-areas/spec.md

Co-authored-by: stigi <13815+stigi@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-04-03 09:42:51 +00:00 • committed by GitHub
commit 5979296f3b
4 changed files with 20 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

14
docs/spec-drift.md
View file

@ -8,12 +8,7 @@ This document lists all known drifts between the OpenSpec specifications in `ope
## Active Drifts
### 1. No-go areas are converted to circles for BRouter, not passed as polygons
- **Spec**: `openspec/specs/brouter-integration/spec.md` — "BRouter request includes nogo parameters for each polygon"
- **Implementation**: `apps/planner/app/lib/brouter.ts` (`noGoAreasToParam()`) converts each polygon to a circle by computing the centroid and using the maximum distance from centroid to any vertex as the radius. BRouter receives `lon,lat,radius` parameters, not polygon coordinates.
- **Impact**: Routing avoidance is approximate. Elongated or concave polygons may not be accurately represented as circles, allowing routes to pass through parts of the drawn area.
- **Resolution options**: Update the spec to document the circle approximation (BRouter only supports circle-based no-go areas), or implement polygon decomposition into multiple overlapping circles for better coverage.
None — all identified drifts have been resolved.
---
@ -23,9 +18,10 @@ Previously identified drifts that have been fixed via code changes or spec updat
| # | Drift | Fixed in | Resolution |
|---|-------|----------|------------|
| 2 | PostGIS `geom` column never populated | PR #150, #151 | `setGeomFromGpx()` now populates geometry via `ST_GeomFromGeoJSON` on route/activity creation |
| 3 | Planner metrics gauges always zero | PR #149 | Gauges wired to `.inc()`/`.dec()` in `yjs-server.ts` on client connect/disconnect |
| 4 | Email provider spec said Resend, impl uses SMTP | PR #153 | Spec updated to document Nodemailer + SMTP |
| 1 | PostGIS `geom` column never populated | PR #150, #151 | `setGeomFromGpx()` now populates geometry via `ST_GeomFromGeoJSON` on route/activity creation |
| 2 | Planner metrics gauges always zero | PR #149 | Gauges wired to `.inc()`/`.dec()` in `yjs-server.ts` on client connect/disconnect |
| 3 | Email provider spec said Resend, impl uses SMTP | PR #153 | Spec updated to document Nodemailer + SMTP |
| 4 | No-go areas converted to circles instead of polygons | PR #155 | `noGoAreasToParam()` now passes polygon vertices directly via BRouter's `polygons` parameter |
| 5 | Server type spec said CX21, Terraform has cx23 | PR #153 | Spec updated to document cx23 |
| 6 | Secret files split into two instead of one | PR #153 | Spec updated to document `secrets.app.env` + `secrets.infra.env` split |
| 7 | BRouter host failover spec said "within 5 seconds" | PR #153 | Spec updated to document immediate deterministic election |