fix(journal): fail loud in production when secrets are unset
Adds `requireSecret(name, devFallback)` in lib/config.server.ts and `getDatabaseUrl()` in @trails-cool/db. Both: - return the env var when set, - fall back to the dev default in non-production, - throw at boot in production if the env var is missing OR matches the known dev fallback (which would otherwise silently ship a public secret / point at localhost). Applied to: - JWT_SECRET (lib/jwt.server.ts) — was `?? "dev-jwt-secret-change-in-production"` - SESSION_SECRET (lib/auth/session.server.ts) — was `?? "dev-secret-change-in-production"` - DATABASE_URL (server.ts health + boss; packages/db migrate-data) — was `?? "postgres://trails:trails@localhost:5432/trails"` Why: these strings are in the repo and known to attackers. A misconfigured prod deploy that forgot to set them would either run with guessable signing keys (full session/JWT forgery) or connect to a non-existent localhost DB. Better to refuse to start than to silently operate insecurely. Tests: - packages/db/src/get-database-url.test.ts (5 cases) - lib/config.server.test.ts gains `requireSecret` cases (4 new) Full repo: pnpm typecheck, pnpm lint, pnpm test all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
742065c319
commit
5a7bb76ff1
8 changed files with 138 additions and 10 deletions
44
packages/db/src/get-database-url.test.ts
Normal file
44
packages/db/src/get-database-url.test.ts
Normal file
|
|
@ -0,0 +1,44 @@
|
|||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
|
||||
const DEV = "postgres://trails:trails@localhost:5432/trails";
|
||||
|
||||
describe("getDatabaseUrl", () => {
|
||||
beforeEach(() => {
|
||||
vi.resetModules();
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
it("uses the override argument when provided", async () => {
|
||||
vi.stubEnv("NODE_ENV", "production");
|
||||
const { getDatabaseUrl } = await import("./index.ts");
|
||||
expect(getDatabaseUrl("postgres://override/db")).toBe("postgres://override/db");
|
||||
});
|
||||
|
||||
it("returns DATABASE_URL when set", async () => {
|
||||
vi.stubEnv("NODE_ENV", "production");
|
||||
vi.stubEnv("DATABASE_URL", "postgres://real-prod/db");
|
||||
const { getDatabaseUrl } = await import("./index.ts");
|
||||
expect(getDatabaseUrl()).toBe("postgres://real-prod/db");
|
||||
});
|
||||
|
||||
it("falls back to the dev URL in development", async () => {
|
||||
vi.stubEnv("NODE_ENV", "development");
|
||||
delete process.env.DATABASE_URL;
|
||||
const { getDatabaseUrl } = await import("./index.ts");
|
||||
expect(getDatabaseUrl()).toBe(DEV);
|
||||
});
|
||||
|
||||
it("throws in production when DATABASE_URL is unset", async () => {
|
||||
vi.stubEnv("NODE_ENV", "production");
|
||||
delete process.env.DATABASE_URL;
|
||||
const { getDatabaseUrl } = await import("./index.ts");
|
||||
expect(() => getDatabaseUrl()).toThrow(/DATABASE_URL/);
|
||||
});
|
||||
|
||||
it("throws in production when DATABASE_URL matches the dev default", async () => {
|
||||
vi.stubEnv("NODE_ENV", "production");
|
||||
vi.stubEnv("DATABASE_URL", DEV);
|
||||
const { getDatabaseUrl } = await import("./index.ts");
|
||||
expect(() => getDatabaseUrl()).toThrow(/dev default/);
|
||||
});
|
||||
});
|
||||
|
|
@ -3,10 +3,32 @@ import postgres from "postgres";
|
|||
import * as plannerSchema from "./schema/planner.ts";
|
||||
import * as journalSchema from "./schema/journal.ts";
|
||||
|
||||
const DEV_DB_URL = "postgres://trails:trails@localhost:5432/trails";
|
||||
|
||||
/**
|
||||
* Resolve the database URL with fail-loud semantics in production.
|
||||
* In dev/test we silently fall back to the local Compose URL so the
|
||||
* loop keeps working; in prod we refuse to start rather than
|
||||
* silently pointing at localhost (which either won't resolve, or
|
||||
* worse, will connect to an unintended database on the host).
|
||||
*/
|
||||
export function getDatabaseUrl(override?: string): string {
|
||||
if (override) return override;
|
||||
const url = process.env.DATABASE_URL;
|
||||
if (process.env.NODE_ENV === "production") {
|
||||
if (!url || url === DEV_DB_URL) {
|
||||
throw new Error(
|
||||
"Refusing to start: DATABASE_URL is unset or matches the dev default. " +
|
||||
"Set DATABASE_URL to the production connection string.",
|
||||
);
|
||||
}
|
||||
return url;
|
||||
}
|
||||
return url ?? DEV_DB_URL;
|
||||
}
|
||||
|
||||
export function createDb(connectionString?: string) {
|
||||
const client = postgres(
|
||||
connectionString ?? process.env.DATABASE_URL ?? "postgres://trails:trails@localhost:5432/trails",
|
||||
);
|
||||
const client = postgres(getDatabaseUrl(connectionString));
|
||||
return drizzle(client, {
|
||||
schema: { ...plannerSchema, ...journalSchema },
|
||||
});
|
||||
|
|
|
|||
|
|
@ -10,13 +10,13 @@ import { readdirSync, readFileSync } from "node:fs";
|
|||
import path from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import postgres from "postgres";
|
||||
import { getDatabaseUrl } from "./index.ts";
|
||||
|
||||
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
||||
const migrationsDir = path.resolve(__dirname, "..", "migrations");
|
||||
|
||||
async function main() {
|
||||
const url = process.env.DATABASE_URL ?? "postgres://trails:trails@localhost:5432/trails";
|
||||
const sql = postgres(url);
|
||||
const sql = postgres(getDatabaseUrl());
|
||||
try {
|
||||
const files = readdirSync(migrationsDir)
|
||||
.filter((f) => f.endsWith(".sql"))
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue