trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove sync parseGpx, use parseGpxAsync everywhere

Browse source 
parseGpx (sync) needs browser DOMParser which doesn't exist on the
server — it silently failed in every server-side caller. Removed the
export and migrated all callers to parseGpxAsync. Updated tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-04-02 20:29:04 +01:00
parent d5bcecb345
commit 5f3d4ae846
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
5 changed files with 29 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

36
packages/gpx/src/parse.test.ts
View file

@ -1,5 +1,5 @@
import { describe, it, expect } from "vitest";
import { parseGpx } from "./parse.ts";
import { parseGpxAsync } from "./parse.ts";
const sampleGpx = `<?xml version="1.0" encoding="UTF-8"?>
<gpx version="1.1" creator="test" xmlns="http://www.topografix.com/GPX/1/1">
@ -15,42 +15,50 @@ const sampleGpx = `<?xml version="1.0" encoding="UTF-8"?>
</trk>
</gpx>`;
describe("parseGpx", () => {
it("parses route name", () => {
const result = parseGpx(sampleGpx);
describe("parseGpxAsync", () => {
it("parses route name", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.name).toBe("Test Route");
});
it("parses waypoints with lat, lon, and name", () => {
const result = parseGpx(sampleGpx);
it("parses waypoints with lat, lon, and name", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.waypoints).toHaveLength(2);
expect(result.waypoints[0]).toEqual({ lat: 52.52, lon: 13.405, name: "Berlin" });
expect(result.waypoints[1]).toEqual({ lat: 48.137, lon: 11.576, name: "Munich" });
});
it("parses track points with elevation", () => {
const result = parseGpx(sampleGpx);
it("parses track points with elevation", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.tracks).toHaveLength(1);
expect(result.tracks[0]).toHaveLength(3);
expect(result.tracks[0]![0]).toEqual({ lat: 52.52, lon: 13.405, ele: 34, time: undefined });
});
it("computes elevation gain and loss", () => {
const result = parseGpx(sampleGpx);
it("computes elevation gain and loss", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.elevation.gain).toBeGreaterThan(0);
expect(result.elevation.loss).toBe(0); // monotonically increasing elevation
expect(result.elevation.gain).toBe(485); // 113-34 + 519-113
});
it("builds elevation profile", () => {
const result = parseGpx(sampleGpx);
it("builds elevation profile", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.elevation.profile).toHaveLength(3);
expect(result.elevation.profile[0]!.distance).toBe(0);
expect(result.elevation.profile[0]!.elevation).toBe(34);
expect(result.elevation.profile[2]!.distance).toBeGreaterThan(0);
});
it("throws on invalid XML", () => {
expect(() => parseGpx("not xml at all <<<<")).toThrow("Invalid GPX XML");
it("computes total distance independently of elevation", async () => {
const result = await parseGpxAsync(sampleGpx);
expect(result.distance).toBeGreaterThan(0);
// Berlin to Munich is ~500km, our 3-point track should be in that range
expect(result.distance).toBeGreaterThan(400_000);
expect(result.distance).toBeLessThan(600_000);
});
it("throws on invalid XML", async () => {
await expect(parseGpxAsync("not xml at all <<<<")).rejects.toThrow();
});
});