fix(journal): remove ineffective dynamic imports
Rollup was warning on 5 modules that were both dynamically and statically imported. With static importers in the same chunk, the dynamic forms buy no chunking benefit — they were leftovers from earlier cycle-avoidance workarounds that no longer apply. Converted to static: - @trails-cool/gpx (routes.\$id.server.ts, sync.import.\$provider.server.ts) - logger.server (boss.server.ts — comment claimed test cycles, but tests pass) - boss.server (activities.server.ts at two sites) - connected-services/manager (komoot/importer.ts, wahoo/importer.ts) - notifications.server (root.tsx) Kept dynamic: fit-file-parser in sync.import.\$provider.server.ts — it's heavy and only the FIT ingestion path needs it, no other static importers exist, so the dynamic actually does chunk-split it. Build is now warning-free. Full repo: pnpm typecheck, pnpm lint, pnpm test, pnpm build all green. 192 tests passed (up from 181 — rate-limit test from #424 + others). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
c6d135945a
commit
9c6407423a
7 changed files with 13 additions and 14 deletions
|
|
@ -8,6 +8,7 @@
|
|||
import { decrypt } from "../../../crypto.server.ts";
|
||||
import { fetchKomootTours, fetchKomootTourGpx } from "../../../komoot.server.ts";
|
||||
import { isAlreadyImported, importActivity } from "../../../sync/imports.server.ts";
|
||||
import { getServiceById } from "../../manager.ts";
|
||||
import type {
|
||||
CapabilityContext,
|
||||
ImportableList,
|
||||
|
|
@ -58,7 +59,6 @@ export const komootImporter: Importer = {
|
|||
return ctx.withFreshCredentials(async (rawCreds) => {
|
||||
const creds = rawCreds as KomootCreds;
|
||||
|
||||
const { getServiceById } = await import("../../manager.ts");
|
||||
const service = await getServiceById(ctx.serviceId);
|
||||
if (!service) throw new Error(`Connected service ${ctx.serviceId} not found`);
|
||||
|
||||
|
|
|
|||
|
|
@ -7,6 +7,7 @@
|
|||
import { fitToGpx } from "../../fit.ts";
|
||||
import { fetchWithTimeout } from "../../../http.server.ts";
|
||||
import { importActivity, isAlreadyImported } from "../../../sync/imports.server.ts";
|
||||
import { getServiceById } from "../../manager.ts";
|
||||
import type {
|
||||
CapabilityContext,
|
||||
ImportableList,
|
||||
|
|
@ -116,7 +117,6 @@ export const wahooImporter: Importer = {
|
|||
// Resolve the connected service's user id via the capability context.
|
||||
// The caller (route handler) supplies userId out-of-band — for now the
|
||||
// route handler bridges the gap. We use the manager's getServiceById.
|
||||
const { getServiceById } = await import("../../manager.ts");
|
||||
const service = await getServiceById(ctx.serviceId);
|
||||
if (!service) throw new Error(`Connected service ${ctx.serviceId} not found`);
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue