trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ci: supply throwaway JWT/SESSION secrets for E2E (NODE_ENV=production)

Browse source 
pnpm test:e2e runs via react-router serve which boots with
NODE_ENV=production; the new requireSecret() guard refuses to start
without explicit values. CI now supplies CI-only throwaway secrets so
the guard still bites in real prod deploys without breaking the test
job.
This commit is contained in:
Ullrich Schäfer 2026-05-24 11:40:24 +02:00
parent 5a7bb76ff1
commit 9d48d26a6e
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/ci.yml vendored
View file

@ -257,6 +257,12 @@ jobs:
BROUTER_URL: http://localhost:17777 BROUTER_URL: http://localhost:17777
E2E: "true" E2E: "true"
INTEGRATION_SECRET: ${{ secrets.INTEGRATION_SECRET }} INTEGRATION_SECRET: ${{ secrets.INTEGRATION_SECRET }}
# pnpm test:e2e starts the server via `react-router serve`, which
# boots with NODE_ENV=production. requireSecret() refuses to start
# in production without these set — supply random throwaway values
# for CI so the fail-loud guard still bites in real prod deploys.
JWT_SECRET: ci-jwt-secret-only-for-e2e-do-not-reuse
SESSION_SECRET: ci-session-secret-only-for-e2e-do-not-reuse
- name: Playwright job summary - name: Playwright job summary
if: ${{ !cancelled() }} if: ${{ !cancelled() }}