trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(ts): eliminate the remaining 4 \as any\ casts in production code

Browse source 
Followup to #447. The audit ran on \`as unknown as\` first; this PR
closes out \`as any\` separately. After this, \`grep -rn ' as any\\b'
apps/ packages/\` returns 0 (excluding tests and node_modules).

## Sites fixed

**\`apps/journal/server.ts\`** + **\`packages/jobs/src/types.ts\`** —
\`komootBulkImportJob as any\`. The job had a typed payload
(\`JobDefinition<KomootBulkImportData>\`) but the worker's
\`JobDefinition[]\` array forced a contravariance cast at every site
that mixed typed and untyped jobs. Dropped the generic from
\`JobDefinition\` entirely; handlers narrow their own \`job.data\`. Only
one job (komoot-bulk-import) used the generic, so the surface is tiny.

**\`apps/journal/app/lib/connected-services/fit.ts\`** + same pattern in
\`routes/sync.import.\$provider.server.ts\` — \`parser.parse(buffer as any,
(err: unknown, d: any) => ...)\`. fit-file-parser's TypeScript types
require \`Buffer<ArrayBuffer>\` specifically; a generic Node \`Buffer\`
is structurally \`Buffer<ArrayBufferLike>\` (which includes
SharedArrayBuffer). The runtime accepts either, so narrowed the cast
to \`as Buffer<ArrayBuffer>\` — still a cast, but precise about what
we're asserting and why. Removed the \`(err, d: any) => …\` ad-hoc
callback typings; the library exports a proper \`FitParserCallback\`.

**\`apps/mobile/lib/editor/RouteMap.tsx\`** — \`onLongPress\` handler
took \`(event: any)\`. maplibre-react-native v11 generates the event
type via React Native codegen but doesn't re-export it as a public
TypeScript type. Replaced with a local structural slice of the parts
we actually read.

Net: 4 \`as any\` sites in prod code → 0. \`pnpm typecheck\` / \`lint\` /
\`test\` all green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-05-26 07:11:02 +02:00
parent 2fc09165da
commit b0b58d36fb
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
6 changed files with 31 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/jobs/src/types.ts
View file

@ -1,8 +1,16 @@
import type { Job } from "pg-boss";
export interface JobDefinition<T extends object = object> {
/**
* A pg-boss job definition. The payload type is intentionally
* `unknown` at this boundary: a heterogeneous `JobDefinition[]` array
* (e.g. the one in `apps/journal/server.ts`) was previously forced to
* cast each typed job to `any` because of contravariance — a handler
* taking `Job<SpecificPayload>` is not assignable to one taking
* `Job<object>`. Handlers narrow internally instead.
*/
export interface JobDefinition {
name: string;
handler: (jobs: Job<T>[]) => Promise<unknown>;
handler: (jobs: Job<unknown>[]) => Promise<unknown>;
cron?: string;
retryLimit?: number;
expireInSeconds?: number;