Add app navigation bars to Journal and Planner

Journal gets a nav bar in root.tsx with conditional links: Routes and
Activities for authenticated users, Sign In and Register for guests.
Active route is highlighted via useLocation(). User menu shows username
linking to profile and a logout button.

Planner SessionView header title becomes a home link back to /.

Adds i18n keys (en + de) for all nav labels. Updates E2E tests to use
scoped nav selectors now that links appear in both nav bar and page body.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-03-25 04:11:30 +01:00 committed by GitHub
parent a9e29b2950
commit bb4f193405
7 changed files with 124 additions and 16 deletions

View file

@ -1,5 +1,5 @@
import { useEffect } from "react"; import { useEffect } from "react";
import { Links, Meta, Outlet, Scripts, ScrollRestoration, isRouteErrorResponse } from "react-router"; import { Links, Meta, Outlet, Scripts, ScrollRestoration, isRouteErrorResponse, useLocation, Form, Link } from "react-router";
import type { LinksFunction } from "react-router"; import type { LinksFunction } from "react-router";
import type { Route } from "./+types/root"; import type { Route } from "./+types/root";
import * as Sentry from "@sentry/react"; import * as Sentry from "@sentry/react";
@ -35,6 +35,75 @@ export async function loader({ request }: Route.LoaderArgs) {
return { user: user ? { id: user.id, username: user.username } : null }; return { user: user ? { id: user.id, username: user.username } : null };
} }
function NavBar({ user }: { user: { id: string; username: string } | null }) {
const { t } = useTranslation("journal");
const location = useLocation();
const isActive = (path: string) =>
location.pathname === path || location.pathname.startsWith(path + "/");
const linkClass = (path: string) =>
`text-sm font-medium ${
isActive(path)
? "text-blue-600"
: "text-gray-600 hover:text-gray-900"
}`;
return (
<nav className="border-b border-gray-200 bg-white px-4 py-2">
<div className="mx-auto flex max-w-6xl items-center justify-between">
<div className="flex items-center gap-6">
<Link to="/" className="text-lg font-semibold text-gray-900">
{t("title")}
</Link>
{user && (
<>
<Link to="/routes" className={linkClass("/routes")}>
{t("nav.routes")}
</Link>
<Link to="/activities" className={linkClass("/activities")}>
{t("nav.activities")}
</Link>
</>
)}
</div>
<div className="flex items-center gap-4">
{user ? (
<>
<Link
to={`/users/${user.username}`}
className={linkClass(`/users/${user.username}`)}
>
{user.username}
</Link>
<Form method="post" action="/auth/logout">
<button
type="submit"
className="text-sm font-medium text-gray-600 hover:text-gray-900"
>
{t("nav.logout")}
</button>
</Form>
</>
) : (
<>
<Link to="/auth/login" className={linkClass("/auth/login")}>
{t("nav.login")}
</Link>
<Link
to="/auth/register"
className="rounded-md bg-blue-600 px-3 py-1.5 text-sm font-medium text-white hover:bg-blue-700"
>
{t("nav.register")}
</Link>
</>
)}
</div>
</div>
</nav>
);
}
export default function App({ loaderData }: Route.ComponentProps) { export default function App({ loaderData }: Route.ComponentProps) {
const user = loaderData?.user; const user = loaderData?.user;
useEffect(() => { useEffect(() => {
@ -45,7 +114,12 @@ export default function App({ loaderData }: Route.ComponentProps) {
} }
}, [user]); }, [user]);
return <Outlet />; return (
<>
<NavBar user={user ?? null} />
<Outlet />
</>
);
} }
export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) { export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) {

View file

@ -1,5 +1,6 @@
import { Suspense, lazy, useState, useCallback, useEffect } from "react"; import { Suspense, lazy, useState, useCallback, useEffect } from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { Link } from "react-router";
import * as Sentry from "@sentry/react"; import * as Sentry from "@sentry/react";
import { useYjs } from "~/lib/use-yjs"; import { useYjs } from "~/lib/use-yjs";
import { useRouting } from "~/lib/use-routing"; import { useRouting } from "~/lib/use-routing";
@ -49,7 +50,9 @@ export function SessionView({ sessionId, callbackUrl, callbackToken, returnUrl,
<> <>
<header className="flex flex-wrap items-center justify-between gap-2 border-b border-gray-200 px-4 py-2"> <header className="flex flex-wrap items-center justify-between gap-2 border-b border-gray-200 px-4 py-2">
<div className="flex items-center gap-2 md:gap-4"> <div className="flex items-center gap-2 md:gap-4">
<h1 className="hidden text-lg font-semibold text-gray-900 sm:block">{t("title")}</h1> <Link to="/" className="hidden text-lg font-semibold text-gray-900 hover:text-blue-600 sm:block">
{t("title")}
</Link>
<ProfileSelector yjs={yjs} /> <ProfileSelector yjs={yjs} />
</div> </div>
<div className="flex items-center gap-3"> <div className="flex items-center gap-3">

View file

@ -9,8 +9,9 @@ test.describe("Journal", () => {
test("shows register and sign in when logged out", async ({ page }) => { test("shows register and sign in when logged out", async ({ page }) => {
await page.goto("/"); await page.goto("/");
await expect(page.getByRole("link", { name: "Register" })).toBeVisible(); // Nav bar has Register and Sign In links
await expect(page.getByRole("link", { name: "Sign in" })).toBeVisible(); await expect(page.getByRole("navigation").getByRole("link", { name: "Register" })).toBeVisible();
await expect(page.getByRole("navigation").getByRole("link", { name: "Sign In" })).toBeVisible();
}); });
test("registration page renders correctly", async ({ page }) => { test("registration page renders correctly", async ({ page }) => {
@ -29,6 +30,17 @@ test.describe("Journal", () => {
await expect(page.getByText(/magic link/i)).toBeVisible(); await expect(page.getByText(/magic link/i)).toBeVisible();
}); });
test("nav bar shows on all pages", async ({ page }) => {
await page.goto("/");
const nav = page.getByRole("navigation");
await expect(nav).toBeVisible();
// Logo/title links home
await expect(nav.getByRole("link", { name: "trails.cool" })).toBeVisible();
// Logged-out nav does not show Routes or Activities
await expect(nav.getByRole("link", { name: "Routes" })).not.toBeVisible();
await expect(nav.getByRole("link", { name: "Activities" })).not.toBeVisible();
});
test("routes page redirects to login when not authenticated", async ({ page }) => { test("routes page redirects to login when not authenticated", async ({ page }) => {
await page.goto("/routes"); await page.goto("/routes");
await expect(page).toHaveURL(/auth\/login/); await expect(page).toHaveURL(/auth\/login/);

View file

@ -20,7 +20,8 @@ test.describe("Planner", () => {
const { url } = await response.json(); const { url } = await response.json();
await page.goto(url); await page.goto(url);
await expect(page.getByText("trails.cool Planner")).toBeVisible(); // Title is now a home link
await expect(page.getByRole("link", { name: "trails.cool Planner" })).toBeVisible();
await expect(page.locator(".leaflet-container")).toBeVisible({ timeout: 10000 }); await expect(page.locator(".leaflet-container")).toBeVisible({ timeout: 10000 });
}); });

View file

@ -1,18 +1,18 @@
## 1. Journal Navigation Bar ## 1. Journal Navigation Bar
- [ ] 1.1 Add nav bar to Journal root Layout — show "Routes", "Activities" links when logged in; "Login", "Register" when logged out - [x] 1.1 Add nav bar to Journal root Layout — show "Routes", "Activities" links when logged in; "Login", "Register" when logged out
- [ ] 1.2 Add user menu to nav bar — username/display name linking to profile, logout button - [x] 1.2 Add user menu to nav bar — username/display name linking to profile, logout button
- [ ] 1.3 Highlight active nav item based on current route - [x] 1.3 Highlight active nav item based on current route
- [ ] 1.4 Add i18n keys for nav labels (en + de): routes, activities, profile, logout - [x] 1.4 Add i18n keys for nav labels (en + de): routes, activities, profile, logout
## 2. Planner Navigation ## 2. Planner Navigation
- [ ] 2.1 Add "Start Planning" CTA button on Planner home page linking to `/new` - [x] 2.1 Add "Start Planning" CTA button on Planner home page linking to `/new` (already done in planner-landing-page change)
- [ ] 2.2 Add home link (logo or text) to SessionView header - [x] 2.2 Add home link (logo or text) to SessionView header
- [ ] 2.3 Add i18n keys for planner nav (en + de): startPlanning, home - [x] 2.3 Add i18n keys for planner nav (en + de): startPlanning, home
## 3. Verify ## 3. Verify
- [ ] 3.1 Verify all Journal routes are reachable via navigation (routes, activities, profile, auth, privacy) - [x] 3.1 Verify all Journal routes are reachable via navigation (routes, activities, profile, auth, privacy)
- [ ] 3.2 Verify Planner home → new session → back to home works - [x] 3.2 Verify Planner home → new session → back to home works
- [ ] 3.3 Update E2E tests if navigation changes affect existing selectors - [x] 3.3 Update E2E tests if navigation changes affect existing selectors

View file

@ -14,6 +14,7 @@ export default {
planner: { planner: {
title: "trails.cool Planer", title: "trails.cool Planer",
subtitle: "Gemeinsame Routenplanung", subtitle: "Gemeinsame Routenplanung",
home: "Startseite",
newSession: "Neue Sitzung", newSession: "Neue Sitzung",
saveRoute: "Route speichern", saveRoute: "Route speichern",
exportGpx: "GPX exportieren", exportGpx: "GPX exportieren",
@ -65,6 +66,14 @@ export default {
journal: { journal: {
title: "trails.cool", title: "trails.cool",
subtitle: "Dein Outdoor-Aktivitäten-Tagebuch", subtitle: "Dein Outdoor-Aktivitäten-Tagebuch",
nav: {
routes: "Routen",
activities: "Aktivitäten",
login: "Anmelden",
register: "Registrieren",
profile: "Profil",
logout: "Abmelden",
},
welcome: "Willkommen,", welcome: "Willkommen,",
addPasskeyPrompt: "Füge einen Passkey hinzu, um dich schneller auf diesem Gerät anzumelden.", addPasskeyPrompt: "Füge einen Passkey hinzu, um dich schneller auf diesem Gerät anzumelden.",
addPasskey: "Passkey hinzufügen", addPasskey: "Passkey hinzufügen",

View file

@ -14,6 +14,7 @@ export default {
planner: { planner: {
title: "trails.cool Planner", title: "trails.cool Planner",
subtitle: "Collaborative route planning", subtitle: "Collaborative route planning",
home: "Home",
newSession: "New Session", newSession: "New Session",
saveRoute: "Save Route", saveRoute: "Save Route",
exportGpx: "Export GPX", exportGpx: "Export GPX",
@ -65,6 +66,14 @@ export default {
journal: { journal: {
title: "trails.cool", title: "trails.cool",
subtitle: "Your outdoor activity journal", subtitle: "Your outdoor activity journal",
nav: {
routes: "Routes",
activities: "Activities",
login: "Sign In",
register: "Register",
profile: "Profile",
logout: "Log Out",
},
welcome: "Welcome,", welcome: "Welcome,",
addPasskeyPrompt: "Add a passkey for faster sign-in on this device.", addPasskeyPrompt: "Add a passkey for faster sign-in on this device.",
addPasskey: "Add Passkey", addPasskey: "Add Passkey",