From c33c8da09b48cb6394a7fa46208e2e96627996a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ullrich=20Sch=C3=A4fer?= Date: Mon, 13 Apr 2026 00:10:36 +0200 Subject: [PATCH] Fix CI typecheck: disable noUncheckedSideEffectImports TS 5.9 enables noUncheckedSideEffectImports under strict mode, which errors on CSS side-effect imports (e.g. leaflet/dist/leaflet.css). These imports are resolved by bundlers (Vite/Metro), not tsc. Set noUncheckedSideEffectImports: false in the shared tsconfig base. Reverts the unnecessary leaflet devDependencies on the map package since this base config fix handles it properly. Co-Authored-By: Claude Opus 4.6 (1M context) --- packages/map/package.json | 5 ----- pnpm-lock.yaml | 12 ++++-------- tsconfig.base.json | 1 + 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/packages/map/package.json b/packages/map/package.json index 11e440b..e0575ea 100644 --- a/packages/map/package.json +++ b/packages/map/package.json @@ -20,10 +20,5 @@ "react-dom": ">=18", "leaflet": ">=1.9", "react-leaflet": ">=5" - }, - "devDependencies": { - "@types/leaflet": "^1.9.21", - "leaflet": "^1.9.4", - "react-leaflet": "^5.0.0" } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 38172df..3a3a585 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -517,21 +517,17 @@ importers: '@trails-cool/map-core': specifier: workspace:* version: link:../map-core + leaflet: + specifier: '>=1.9' + version: 1.9.4 react: specifier: '>=18' version: 19.2.5 react-dom: specifier: '>=18' version: 19.2.5(react@19.2.5) - devDependencies: - '@types/leaflet': - specifier: ^1.9.21 - version: 1.9.21 - leaflet: - specifier: ^1.9.4 - version: 1.9.4 react-leaflet: - specifier: ^5.0.0 + specifier: '>=5' version: 5.0.0(leaflet@1.9.4)(react-dom@19.2.5(react@19.2.5))(react@19.2.5) packages/map-core: {} diff --git a/tsconfig.base.json b/tsconfig.base.json index ece6172..9166196 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -15,6 +15,7 @@ "declarationMap": true, "sourceMap": true, "noUncheckedIndexedAccess": true, + "noUncheckedSideEffectImports": false, "noEmit": true, "allowImportingTsExtensions": true },