trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Gracefully handle missing DB in Planner routes

Browse source 
Wrap session API and loader in try/catch to return 503 instead
of crashing the server when PostgreSQL is unavailable. This
prevents E2E test failures in CI where no DB is running.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-03-24 23:37:05 +01:00
parent e86ff5a8a3
commit cadcf753a7
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
2 changed files with 43 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

49
apps/planner/app/routes/api.sessions.ts
View file

@ -15,29 +15,40 @@ export async function action({ request }: Route.ActionArgs) {
gpx?: string;
};
const session = await createSession({ callbackUrl, callbackToken });
try {
const session = await createSession({ callbackUrl, callbackToken });
let initialWaypoints: Array<{ lat: number; lon: number; name?: string }> | undefined;
if (gpx) {
try {
const gpxData = await parseGpxAsync(gpx);
initialWaypoints = gpxData.waypoints;
} catch (_e) {
// Continue with empty session if GPX is invalid
let initialWaypoints: Array<{ lat: number; lon: number; name?: string }> | undefined;
if (gpx) {
try {
const gpxData = await parseGpxAsync(gpx);
initialWaypoints = gpxData.waypoints;
} catch {
// Continue with empty session if GPX is invalid
}
}
}
return data(
{
sessionId: session.id,
url: `/session/${session.id}`,
initialWaypoints,
},
{ status: 201 },
);
return data(
{
sessionId: session.id,
url: `/session/${session.id}`,
initialWaypoints,
},
{ status: 201 },
);
} catch (e) {
return data(
{ error: "Database unavailable", details: (e as Error).message },
{ status: 503 },
);
}
}
export async function loader(_args: Route.LoaderArgs) {
const sessions = await listSessions();
return data({ sessions });
try {
const sessions = await listSessions();
return data({ sessions });
} catch {
return data({ sessions: [], error: "Database unavailable" });
}
}

21
apps/planner/app/routes/session.$id.tsx
View file

@ -14,15 +14,20 @@ export function meta(_args: Route.MetaArgs) {
}
export async function loader({ params }: Route.LoaderArgs) {
const session = await getSession(params.id);
if (!session) {
throw data({ error: "Session not found" }, { status: 404 });
try {
const session = await getSession(params.id);
if (!session) {
throw data({ error: "Session not found" }, { status: 404 });
}
return data({
sessionId: session.id,
callbackUrl: session.callbackUrl ?? null,
callbackToken: session.callbackToken ?? null,
});
} catch (e) {
if (e instanceof Response) throw e; // Re-throw data() responses
throw data({ error: "Database unavailable" }, { status: 503 });
}
return data({
sessionId: session.id,
callbackUrl: session.callbackUrl ?? null,
callbackToken: session.callbackToken ?? null,
});
}
export default function SessionPage({ loaderData }: Route.ComponentProps) {