From e059f36db950f876e82a840dfa16f67c669c79f2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ullrich=20Sch=C3=A4fer?= <hi+github@ullrich.is>
Date: Sun, 10 May 2026 21:53:17 +0200
Subject: [PATCH] Remove broken data URI images from job summary

---
 .github/workflows/ci.yml | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3fabf23..6d12af6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -144,26 +144,6 @@ jobs:
         id: visual-tests
         run: pnpm --filter @trails-cool/planner test:visual
 
-      - name: Write diff images to job summary
-        if: failure() && steps.visual-tests.outcome == 'failure'
-        run: |
-          diffs=$(find apps/planner/.vitest-attachments -name "*-diff-*.png" 2>/dev/null | sort)
-          if [ -z "$diffs" ]; then exit 0; fi
-
-          echo "## Visual regression failures" >> $GITHUB_STEP_SUMMARY
-          echo "" >> $GITHUB_STEP_SUMMARY
-          for diff in $diffs; do
-            name=$(basename "$diff" | sed 's/-diff-chromium-[a-z]*\.png//' | sed 's/-/ /g')
-            b64=$(base64 -w 0 "$diff")
-            echo "### \`$name\`" >> $GITHUB_STEP_SUMMARY
-            echo "<img src=\"data:image/png;base64,$b64\" alt=\"$name diff\" style=\"max-width:100%\">" >> $GITHUB_STEP_SUMMARY
-            echo "" >> $GITHUB_STEP_SUMMARY
-          done
-          echo "To update snapshots if the change is intentional:" >> $GITHUB_STEP_SUMMARY
-          echo '```' >> $GITHUB_STEP_SUMMARY
-          echo "pnpm --filter @trails-cool/planner test:visual:update" >> $GITHUB_STEP_SUMMARY
-          echo '```' >> $GITHUB_STEP_SUMMARY
-
       - name: Post diff comment on PR
         if: failure() && steps.visual-tests.outcome == 'failure' && github.event_name == 'pull_request'
         env:
@@ -172,14 +152,14 @@ jobs:
           diffs=$(find apps/planner/.vitest-attachments -name "*-diff-*.png" 2>/dev/null | sort)
           if [ -z "$diffs" ]; then exit 0; fi
 
-          run_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+          artifact_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
           body="## Visual regression failures"$'\n\n'
           body+="The following tests produced screenshot diffs:"$'\n\n'
           for diff in $diffs; do
             name=$(basename "$diff" | sed 's/-diff-chromium-[a-z]*\.png//' | sed 's/-/ /g')
             body+="- \`$name\`"$'\n'
           done
-          body+=$'\n'"**[View diff images in the job summary]($run_url)**"$'\n\n'
+          body+=$'\n'"**[Download the \`visual-snapshots-diff\` artifact]($artifact_url)** to inspect the diffs locally."$'\n\n'
           body+="To update snapshots if the change is intentional:"$'\n'
           body+="\`\`\`"$'\n'
           body+="pnpm --filter @trails-cool/planner test:visual:update"$'\n'