trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix TypeScript parameter property crash in Node strip-only mode

Browse source 
oauth.server.ts used a TypeScript parameter property (`public code: string`
in constructor) which is not supported by Node.js v25's strip-only TypeScript
mode. This caused the journal to crash-loop on startup after seeding OAuth
clients.

Also enable `erasableSyntaxOnly` in tsconfig.base.json so `pnpm typecheck`
catches any future use of non-erasable TypeScript syntax.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-04-12 14:00:00 +02:00
parent fda376267c
commit e69f93800b
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
apps/journal/app/lib/oauth.server.ts
View file

@ -264,10 +264,9 @@ export async function getAuthenticatedUser(request: Request) {
// --- Error type --- // --- Error type ---
export class OAuthError extends Error { export class OAuthError extends Error {
constructor( code: string;
public code: string, constructor(code: string, message: string) {
message: string,
) {
super(message); super(message);
this.code = code;
} }
} }

1
tsconfig.base.json
View file

@ -17,6 +17,7 @@
"noUncheckedIndexedAccess": true, "noUncheckedIndexedAccess": true,
"noUncheckedSideEffectImports": false, "noUncheckedSideEffectImports": false,
"noEmit": true, "noEmit": true,
"erasableSyntaxOnly": true,
"allowImportingTsExtensions": true "allowImportingTsExtensions": true
}, },
"exclude": ["node_modules", "build", "dist"] "exclude": ["node_modules", "build", "dist"]