trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: add E2E opt-out for fail-loud secret/DB-URL guards

Browse source 
Playwright runs the server via `react-router serve` with
NODE_ENV=production but against a local dev Postgres and local cookie
secrets. The guards added in 5a7bb76 refused to start under that
configuration. `E2E=true` (already set by the CI E2E job) is now the
explicit opt-out: in real production this env var is never set, so the
guard still bites.
This commit is contained in:
Ullrich Schäfer 2026-05-24 11:45:09 +02:00
parent 9d48d26a6e
commit ebedfa257b
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
3 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/db/src/index.ts
View file

@ -15,7 +15,11 @@ const DEV_DB_URL = "postgres://trails:trails@localhost:5432/trails";
export function getDatabaseUrl(override?: string): string {
if (override) return override;
const url = process.env.DATABASE_URL;
if (process.env.NODE_ENV === "production") {
// Playwright runs `react-router serve` which boots with
// NODE_ENV=production, but the CI E2E suite legitimately points at a
// local Postgres using the dev URL. E2E=true is the explicit opt-out.
const isProd = process.env.NODE_ENV === "production" && process.env.E2E !== "true";
if (isProd) {
if (!url || url === DEV_DB_URL) {
throw new Error(
"Refusing to start: DATABASE_URL is unset or matches the dev default. " +