Fix Vitest browser provider setup and test cleanup

- Add @vitest/browser-playwright; use playwright() factory (not string)
- Import page from vitest/browser (not deprecated @vitest/browser/context)
- Add afterEach(cleanup) so each test gets a fresh DOM
- Use oxc transform for JSX instead of esbuild (avoids Vite 8 warning)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-05-10 19:01:24 +02:00
parent 49c0b2d1f4
commit fcc4f88379
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
4 changed files with 37 additions and 14 deletions

View file

@ -1,6 +1,6 @@
import { describe, it, expect } from "vitest"; import { describe, it, expect, afterEach } from "vitest";
import { render } from "@testing-library/react"; import { render, cleanup } from "@testing-library/react";
import { page } from "@vitest/browser/context"; import { page } from "vitest/browser";
import { drawElevationChart } from "./elevation-chart-draw"; import { drawElevationChart } from "./elevation-chart-draw";
import type { DrawChartParams } from "./elevation-chart-draw"; import type { DrawChartParams } from "./elevation-chart-draw";
@ -46,6 +46,7 @@ function ChartFixture({ params }: { params: DrawChartParams }) {
} }
describe("drawElevationChart visual regression", () => { describe("drawElevationChart visual regression", () => {
afterEach(() => cleanup());
it("renders plain color mode", async () => { it("renders plain color mode", async () => {
render(<ChartFixture params={BASE_PARAMS} />); render(<ChartFixture params={BASE_PARAMS} />);
await expect(page.getByTestId("chart")).toMatchScreenshot("plain.png"); await expect(page.getByTestId("chart")).toMatchScreenshot("plain.png");

View file

@ -55,6 +55,7 @@
"@types/react-dom": "catalog:", "@types/react-dom": "catalog:",
"@types/ws": "^8.18.1", "@types/ws": "^8.18.1",
"@vitest/browser": "^4.1.5", "@vitest/browser": "^4.1.5",
"@vitest/browser-playwright": "^4.1.5",
"leaflet.markercluster": "^1.5.3", "leaflet.markercluster": "^1.5.3",
"pino-pretty": "^13.1.3", "pino-pretty": "^13.1.3",
"tailwindcss": "catalog:", "tailwindcss": "catalog:",

View file

@ -1,5 +1,6 @@
import { defineConfig } from "vitest/config"; import { defineConfig } from "vitest/config";
import { resolve } from "node:path"; import { resolve } from "node:path";
import { playwright } from "@vitest/browser-playwright";
// Separate config for Vitest browser visual regression tests. // Separate config for Vitest browser visual regression tests.
// Run with: pnpm --filter @trails-cool/planner test:visual // Run with: pnpm --filter @trails-cool/planner test:visual
@ -10,8 +11,8 @@ import { resolve } from "node:path";
// (.github/workflows/update-visual-snapshots.yml), triggered manually or // (.github/workflows/update-visual-snapshots.yml), triggered manually or
// by adding the `update-snapshots` label to a PR. // by adding the `update-snapshots` label to a PR.
export default defineConfig({ export default defineConfig({
esbuild: { oxc: {
jsx: "automatic", transform: { react: {} },
}, },
resolve: { resolve: {
alias: { alias: {
@ -23,10 +24,7 @@ export default defineConfig({
include: ["app/**/*.browser.test.{ts,tsx}"], include: ["app/**/*.browser.test.{ts,tsx}"],
browser: { browser: {
enabled: true, enabled: true,
// Provider is resolved from whichever @vitest/browser peer is installed. provider: playwright(),
// playwright is the default when @playwright/test is available.
// eslint-disable-next-line @typescript-eslint/no-explicit-any
provider: "playwright" as any,
instances: [{ browser: "chromium" }], instances: [{ browser: "chromium" }],
}, },
}, },

33
pnpm-lock.yaml generated
View file

@ -196,7 +196,7 @@ importers:
version: 8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4) version: 8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)
vitest: vitest:
specifier: ^4.1.5 specifier: ^4.1.5
version: 4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)) version: 4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(@vitest/browser-playwright@4.1.5)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
apps/journal: apps/journal:
dependencies: dependencies:
@ -568,7 +568,10 @@ importers:
version: 8.18.1 version: 8.18.1
'@vitest/browser': '@vitest/browser':
specifier: ^4.1.5 specifier: ^4.1.5
version: 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))) version: 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)
'@vitest/browser-playwright':
specifier: ^4.1.5
version: 4.1.5(playwright@1.59.1)(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)
leaflet.markercluster: leaflet.markercluster:
specifier: ^1.5.3 specifier: ^1.5.3
version: 1.5.3(leaflet@1.9.4) version: 1.5.3(leaflet@1.9.4)
@ -3936,6 +3939,12 @@ packages:
peerDependencies: peerDependencies:
vite: ^6.0.0 || ^7.0.0 || ^8.0.0 vite: ^6.0.0 || ^7.0.0 || ^8.0.0
'@vitest/browser-playwright@4.1.5':
resolution: {integrity: sha512-CWy0lBQJq97nionyJJdnaU4961IXTl43a7UCu5nHy51IoKxAt6PVIJLo+76rVl7KOOgcWHNkG4kbJu/pW7knvA==}
peerDependencies:
playwright: '*'
vitest: 4.1.5
'@vitest/browser@4.1.5': '@vitest/browser@4.1.5':
resolution: {integrity: sha512-iCDGI8c4yg+xmjUg2VsygdAUSIIB4x5Rht/P68OXy1hPELKXHDkzh87lkuTcdYmemRChDkEpB426MmDjzC0ziA==} resolution: {integrity: sha512-iCDGI8c4yg+xmjUg2VsygdAUSIIB4x5Rht/P68OXy1hPELKXHDkzh87lkuTcdYmemRChDkEpB426MmDjzC0ziA==}
peerDependencies: peerDependencies:
@ -11741,7 +11750,20 @@ snapshots:
dependencies: dependencies:
vite: 8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4) vite: 8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)
'@vitest/browser@4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)))': '@vitest/browser-playwright@4.1.5(playwright@1.59.1)(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)':
dependencies:
'@vitest/browser': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)
'@vitest/mocker': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
playwright: 1.59.1
tinyrainbow: 3.1.0
vitest: 4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(@vitest/browser-playwright@4.1.5)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
transitivePeerDependencies:
- bufferutil
- msw
- utf-8-validate
- vite
'@vitest/browser@4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)':
dependencies: dependencies:
'@blazediff/core': 1.9.1 '@blazediff/core': 1.9.1
'@vitest/mocker': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)) '@vitest/mocker': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
@ -11750,7 +11772,7 @@ snapshots:
pngjs: 7.0.0 pngjs: 7.0.0
sirv: 3.0.2 sirv: 3.0.2
tinyrainbow: 3.1.0 tinyrainbow: 3.1.0
vitest: 4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)) vitest: 4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(@vitest/browser-playwright@4.1.5)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
ws: 8.20.0 ws: 8.20.0
transitivePeerDependencies: transitivePeerDependencies:
- bufferutil - bufferutil
@ -16125,7 +16147,7 @@ snapshots:
tsx: 4.21.0 tsx: 4.21.0
yaml: 2.8.4 yaml: 2.8.4
vitest@4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)): vitest@4.1.5(@opentelemetry/api@1.9.1)(@types/node@25.6.2)(@vitest/browser-playwright@4.1.5)(jsdom@29.1.1(canvas@3.2.3))(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)):
dependencies: dependencies:
'@vitest/expect': 4.1.5 '@vitest/expect': 4.1.5
'@vitest/mocker': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4)) '@vitest/mocker': 4.1.5(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))
@ -16150,6 +16172,7 @@ snapshots:
optionalDependencies: optionalDependencies:
'@opentelemetry/api': 1.9.1 '@opentelemetry/api': 1.9.1
'@types/node': 25.6.2 '@types/node': 25.6.2
'@vitest/browser-playwright': 4.1.5(playwright@1.59.1)(vite@8.0.10(@types/node@25.6.2)(esbuild@0.27.7)(jiti@2.7.0)(terser@5.47.1)(tsx@4.21.0)(yaml@2.8.4))(vitest@4.1.5)
jsdom: 29.1.1(canvas@3.2.3) jsdom: 29.1.1(canvas@3.2.3)
transitivePeerDependencies: transitivePeerDependencies:
- msw - msw