trails/apps/journal/app/routes/activities.$id.server.ts
Ullrich Schäfer 279734c607
route-surface-breakdown (Phase 2): async Overpass backfill + SSE
Covers routes/activities that enter the journal without BRouter waytags
(imports, uploads, pre-existing rows):

- overpass-ways.server.ts: server-side Overpass client (way[highway] + geom in
  a bbox, configurable OVERPASS_URLS, timeout + oversized-bbox guard).
- surface-match.server.ts: pure nearest-way map-matcher → per-segment
  surface/highway (unmatched → unknown). Unit-tested.
- surface-backfill pg-boss job: load geom → skip if breakdown exists → Overpass
  → match → computeSurfaceBreakdown → store → emit `surface_breakdown` SSE to
  the owner. Idempotent, retry-safe, best-effort; registered in server.ts.
- Enqueued from createActivity (imports/uploads) + owner-on-open in the route &
  activity detail loaders (non-Planner routes, old rows), deduped via singletonKey.
- useSurfaceBackfillUpdates: detail pages subscribe to /api/events and
  revalidate() when their row's backfill lands (live bars, no reload).
- Privacy manifest updated (DE + EN) for the Overpass bbox lookup.

Tests: matchSurfaces unit; surface-backfill job (mocked Overpass/db/events:
store + emit, skip-if-present, skip-if-no-ways). Verified the real
Overpass→match→breakdown pipeline against a live Berlin bbox (509 ways →
plausible asphalt/paving_stones/footway mix). typecheck + lint + unit
(journal 333) green.

Note: the worker runs via server.ts (prod/staging), not `react-router dev`, so
the live job + SSE exercise on a deployed instance.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-14 19:18:03 +02:00

138 lines
5.4 KiB
TypeScript

// Server-only loader/action for /activities/:id. See `home.server.ts`.
import { data, redirect } from "react-router";
import { canView } from "~/lib/auth.server";
import { getSessionUser, requireSessionUser } from "~/lib/auth/session.server";
import {
getActivity,
deleteActivity,
linkActivityToRoute,
createRouteFromActivity,
updateActivityVisibility,
} from "~/lib/activities.server";
import { deleteImportByActivity } from "~/lib/sync/imports.server";
import { listRoutes } from "~/lib/routes.server";
import { requireOwnedActivity, requireOwnedRoute } from "~/lib/ownership.server";
import { parseGpxAsync, movingTime, elevationSeries } from "@trails-cool/gpx";
import type { ElevationSample } from "@trails-cool/gpx";
import { logger } from "~/lib/logger.server";
import { enqueueOptional } from "~/lib/boss.server";
import type { Visibility } from "@trails-cool/db/schema/journal";
const VISIBILITY_VALUES = new Set<Visibility>(["private", "unlisted", "public"]);
export async function loadActivityDetail(request: Request, id: string | undefined) {
const fetched = await getActivity(id ?? "");
if (!fetched) throw data({ error: "Activity not found" }, { status: 404 });
// Remote-ingested activities have no local detail page — their
// canonical page lives on the origin instance; the feed links there.
if (fetched.ownerId === null) throw data({ error: "Activity not found" }, { status: 404 });
const activity = { ...fetched, ownerId: fetched.ownerId };
const user = await getSessionUser(request);
const isOwner = user?.id === activity.ownerId;
// Visibility gate — public always, unlisted on direct link, private owner-only.
// 404 (not 403) to avoid leaking existence.
if (!canView(activity, user, { asDirectLink: true })) {
throw data({ error: "Activity not found" }, { status: 404 });
}
const userRoutes = isOwner && user ? await listRoutes(user.id) : [];
// Lazily backfill the surface breakdown for the owner's own activities that
// have geometry but no breakdown yet (route-surface-breakdown Path 2). The
// SSE event from the job fills the bars in live. Owner-gated so a random
// viewer can't trigger an Overpass lookup; idempotent via singletonKey.
if (isOwner && activity.geojson && !activity.surfaceBreakdown) {
await enqueueOptional(
"surface-backfill",
{ kind: "activity", id: activity.id },
{ source: "activity-detail" },
{ singletonKey: `surface:activity:${activity.id}` },
);
}
// Moving time + the elevation series are both derived from the GPX (one
// parse). Detail-page only — too costly to parse per row in list views.
let movingTimeSec: number | null = null;
let elevation: ElevationSample[] = [];
if (activity.gpx) {
try {
const parsed = await parseGpxAsync(activity.gpx);
movingTimeSec = movingTime(parsed.tracks);
elevation = elevationSeries(parsed.tracks);
} catch (err) {
logger.warn({ activityId: activity.id, err }, "activity detail: failed to parse gpx");
}
}
return {
activity: {
id: activity.id,
name: activity.name,
description: activity.description,
sportType: activity.sportType,
distance: activity.distance,
elevationGain: activity.elevationGain,
elevationLoss: activity.elevationLoss,
duration: activity.duration,
movingTimeSec,
elevation,
surfaceBreakdown: activity.surfaceBreakdown ?? null,
routeId: activity.routeId,
hasGpx: !!activity.gpx,
geojson: activity.geojson ?? null,
startedAt: activity.startedAt?.toISOString() ?? null,
visibility: activity.visibility,
createdAt: activity.createdAt.toISOString(),
importSource: activity.importSource,
},
isOwner,
routes: userRoutes.map((r) => ({ id: r.id, name: r.name })),
};
}
export async function activityDetailAction(request: Request, id: string | undefined) {
const user = await requireSessionUser(request);
const activityId = id ?? "";
const formData = await request.formData();
const intent = formData.get("intent");
if (intent === "link-route") {
const activity = await requireOwnedActivity(activityId, user.id);
const routeIdRaw = formData.get("routeId") as string;
if (routeIdRaw) {
const route = await requireOwnedRoute(routeIdRaw, user.id);
await linkActivityToRoute(activity, route);
}
return redirect(`/activities/${activityId}`);
}
if (intent === "create-route") {
const activity = await requireOwnedActivity(activityId, user.id);
const routeId = await createRouteFromActivity(activity);
if (routeId) return redirect(`/routes/${routeId}`);
return data({ error: "No GPX data to create route from" }, { status: 400 });
}
if (intent === "delete") {
const activity = await requireOwnedActivity(activityId, user.id);
await deleteImportByActivity(activityId);
await deleteActivity(activity);
return redirect("/activities");
}
if (intent === "set-visibility") {
const raw = formData.get("visibility") as string | null;
if (!raw || !VISIBILITY_VALUES.has(raw as Visibility)) {
return data({ error: "Invalid visibility" }, { status: 400 });
}
const activity = await requireOwnedActivity(activityId, user.id);
await updateActivityVisibility(activity, raw as Visibility);
return redirect(`/activities/${activityId}`);
}
return data({ error: "Unknown action" }, { status: 400 });
}