trails/apps/journal/app/routes/api.v1.routes.$id.ts
Ullrich Schäfer edd2cabf12
DRY up ZodError → FieldError mapping
Five journal API route handlers had the same inline lambda:

    parsed.error.issues.map((i) => ({
      field: i.path.join("."),
      message: i.message,
    }))

Pull it into `zodIssuesToFieldErrors(error)` next to FieldError in
`@trails-cool/api/errors.ts` and re-export it so all five handlers
share the same implementation. The path-flattening rule now lives in
one place, and new routes get it for free.

Public error-response shape is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 11:45:09 +02:00

64 lines
2.2 KiB
TypeScript

import type { Route } from "./+types/api.v1.routes.$id";
import { requireApiUser, apiError } from "~/lib/api-guard.server";
import { getRouteWithVersions, updateRoute, deleteRoute } from "~/lib/routes.server";
import { UpdateRouteRequestSchema, ERROR_CODES, zodIssuesToFieldErrors } from "@trails-cool/api";
/** GET /api/v1/routes/:id — full route detail */
export async function loader({ request, params }: Route.LoaderArgs) {
const user = await requireApiUser(request);
const route = await getRouteWithVersions(params.id);
if (!route || route.ownerId !== user.id) {
return apiError(404, ERROR_CODES.NOT_FOUND, "Route not found");
}
return Response.json({
id: route.id,
name: route.name,
description: route.description,
distance: route.distance,
elevationGain: route.elevationGain,
elevationLoss: route.elevationLoss,
routingProfile: route.routingProfile,
dayBreaks: route.dayBreaks ?? [],
gpx: route.gpx,
geojson: null, // TODO: fetch geojson
versions: route.versions.map((v) => ({
id: v.id,
version: v.version,
createdBy: v.createdBy,
changeDescription: v.changeDescription,
createdAt: v.createdAt.toISOString(),
})),
createdAt: route.createdAt.toISOString(),
updatedAt: route.updatedAt.toISOString(),
});
}
/** PUT /api/v1/routes/:id — update a route */
/** DELETE /api/v1/routes/:id — delete a route */
export async function action({ request, params }: Route.ActionArgs) {
const user = await requireApiUser(request);
if (request.method === "PUT") {
const body = await request.json().catch(() => null);
const parsed = UpdateRouteRequestSchema.safeParse(body);
if (!parsed.success) {
return apiError(400, ERROR_CODES.VALIDATION_ERROR, "Validation failed",
zodIssuesToFieldErrors(parsed.error));
}
await updateRoute(params.id, user.id, parsed.data);
return Response.json({ ok: true });
}
if (request.method === "DELETE") {
const deleted = await deleteRoute(params.id, user.id);
if (!deleted) {
return apiError(404, ERROR_CODES.NOT_FOUND, "Route not found");
}
return new Response(null, { status: 204 });
}
return new Response(null, { status: 405 });
}