0360757ae8
Garmin Connect as the third connected-services provider (spec: garmin-import). The interesting parts: - Push-first ingestion: Garmin has no list endpoint. The webhook normalizes ping (callbackURL) and push (inline) notification batches into events; the slow work (authorized FIT download, FIT→GPX via the shared converter, activity creation) runs in a garmin-import-activity pg-boss job so the webhook answers fast. Callback URLs are validated against Garmin's API host before any fetch (SSRF guard). - History via backfill requests: /sync/import/garmin is a date-range requester with honest async progress (no pick list — the concept doesn't exist in a push model). Ranges chunk to Garmin's 90-day cap; overlaps are free via sync_imports dedupe. Requests persist in import_batches via two new nullable columns (range_start/range_end). - OAuth2 + PKCE on the existing oauth credential kind. Design correction from apply: the verifier rides a short-lived httpOnly cookie scoped to the callback path — the state param is visible in redirect URLs and must never carry it. Manifests opt in via pkce:true. - Deregistration notifications flip the connection to 'revoked' (row kept for audit, imports retained, re-connect prompt shown). - Framework evolutions, all additive: parseWebhook returns WebhookEvent[] (Garmin batches; Wahoo adapted), manifest gains configured()/importUrl/pkce, importActivity accepts summary stats for FIT-less imports, manager gains markRevoked. - Env-gated: no GARMIN_CLIENT_ID → provider hidden on /settings/connections. Privacy manifest entry (DE+EN). i18n en+de. Rollout (§6) stays gated on the Garmin Developer Program application (submitted 2026-06-07). Fixtures are doc-shaped; the staging soak swaps in recorded payloads if shapes differ. Gate: typecheck ✓ lint ✓ unit+integration ✓ e2e 70/72 + both known flakes green isolated ✓ openspec validate ✓ Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
42 lines
1.4 KiB
TypeScript
42 lines
1.4 KiB
TypeScript
// Unit tests for Garmin backfill chunking + request fan-out
|
|
// (spec: garmin-import, "Historical import via backfill").
|
|
|
|
import { describe, it, expect, vi } from "vitest";
|
|
|
|
vi.mock("../../manager.ts", () => ({ withFreshCredentials: vi.fn() }));
|
|
vi.mock("../../../db.ts", () => ({ getDb: () => ({}) }));
|
|
|
|
const { chunkRange, BACKFILL_CHUNK_MS } = await import("./backfill.ts");
|
|
|
|
const DAY = 24 * 60 * 60 * 1000;
|
|
|
|
describe("chunkRange", () => {
|
|
it("returns a single chunk for ranges within the cap", () => {
|
|
const chunks = chunkRange(0, 30 * DAY);
|
|
expect(chunks).toEqual([{ fromMs: 0, toMs: 30 * DAY }]);
|
|
});
|
|
|
|
it("splits ranges larger than the cap, last chunk clamped", () => {
|
|
const chunks = chunkRange(0, 200 * DAY);
|
|
expect(chunks).toHaveLength(3);
|
|
expect(chunks[0]).toEqual({ fromMs: 0, toMs: BACKFILL_CHUNK_MS });
|
|
expect(chunks[2]!.toMs).toBe(200 * DAY);
|
|
// contiguous, no gaps or overlaps
|
|
expect(chunks[1]!.fromMs).toBe(chunks[0]!.toMs);
|
|
expect(chunks[2]!.fromMs).toBe(chunks[1]!.toMs);
|
|
});
|
|
|
|
it("returns [] for empty or inverted ranges", () => {
|
|
expect(chunkRange(5, 5)).toEqual([]);
|
|
expect(chunkRange(10, 5)).toEqual([]);
|
|
});
|
|
|
|
it("covers exactly the requested range at chunk boundaries", () => {
|
|
const chunks = chunkRange(0, 2 * BACKFILL_CHUNK_MS);
|
|
expect(chunks).toHaveLength(2);
|
|
expect(chunks[1]).toEqual({
|
|
fromMs: BACKFILL_CHUNK_MS,
|
|
toMs: 2 * BACKFILL_CHUNK_MS,
|
|
});
|
|
});
|
|
});
|