trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
trails/apps/journal/app/routes
History
Ullrich Schäfer b0b58d36fb
chore(ts): eliminate the remaining 4 \as any\ casts in production code 
Followup to #447. The audit ran on \`as unknown as\` first; this PR
closes out \`as any\` separately. After this, \`grep -rn ' as any\\b'
apps/ packages/\` returns 0 (excluding tests and node_modules).

## Sites fixed

**\`apps/journal/server.ts\`** + **\`packages/jobs/src/types.ts\`** —
\`komootBulkImportJob as any\`. The job had a typed payload
(\`JobDefinition<KomootBulkImportData>\`) but the worker's
\`JobDefinition[]\` array forced a contravariance cast at every site
that mixed typed and untyped jobs. Dropped the generic from
\`JobDefinition\` entirely; handlers narrow their own \`job.data\`. Only
one job (komoot-bulk-import) used the generic, so the surface is tiny.

**\`apps/journal/app/lib/connected-services/fit.ts\`** + same pattern in
\`routes/sync.import.\$provider.server.ts\` — \`parser.parse(buffer as any,
(err: unknown, d: any) => ...)\`. fit-file-parser's TypeScript types
require \`Buffer<ArrayBuffer>\` specifically; a generic Node \`Buffer\`
is structurally \`Buffer<ArrayBufferLike>\` (which includes
SharedArrayBuffer). The runtime accepts either, so narrowed the cast
to \`as Buffer<ArrayBuffer>\` — still a cast, but precise about what
we're asserting and why. Removed the \`(err, d: any) => …\` ad-hoc
callback typings; the library exports a proper \`FitParserCallback\`.

**\`apps/mobile/lib/editor/RouteMap.tsx\`** — \`onLongPress\` handler
took \`(event: any)\`. maplibre-react-native v11 generates the event
type via React Native codegen but doesn't re-export it as a public
TypeScript type. Replaced with a local structural slice of the parts
we actually read.

Net: 4 \`as any\` sites in prod code → 0. \`pnpm typecheck\` / \`lint\` /
\`test\` all green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 07:11:02 +02:00
..
activities.$id.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
activities.$id.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
activities._index.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
activities._index.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
activities.new.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
activities.new.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
api.auth.login.ts fix(journal): rate-limit auth endpoints 2026-05-24 11:51:43 +02:00
api.auth.register.test.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.auth.register.ts fix(journal): rate-limit auth endpoints 2026-05-24 11:51:43 +02:00
api.e2e.komoot.ts Rewrite komoot E2E tests to use server-side seed endpoint 2026-05-23 10:57:16 +02:00
api.e2e.route.$id.ts Fix unused import lint error in api.e2e.route.$id.ts 2026-05-10 15:24:31 +02:00
api.e2e.seed.ts Show POI details (phone, website, opening hours) on Journal route detail page 2026-05-17 23:32:38 +02:00
api.events.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.follows.$id.approve.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.follows.$id.reject.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.metrics.ts Add observability: health endpoints, structured logging, metrics, Grafana stack 2026-03-26 22:59:44 +01:00
api.notifications.$id.read.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.notifications.read-all.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.routes.$id.callback.ts Atomic GPX save: validate + persist row + geometry in one transaction 2026-05-10 15:02:56 +02:00
api.routes.$id.edit-in-planner.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.routes.$id.gpx.ts Add route detail day segment highlighting and per-day GPX export 2026-04-11 00:44:11 +02:00
api.settings.delete-account.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.settings.email.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.settings.passkey.delete.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.settings.profile.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.sync.callback.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.connect.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.disconnect.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.connect.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.import-status.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.import.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.verify.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.push.$provider.$routeId.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.webhook.$provider.test.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.sync.webhook.$provider.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.users.$username.follow.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.users.$username.unfollow.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.v1.activities.$id.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.activities._index.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.auth.devices.$id.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.auth.devices.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.routes.$id.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.routes._index.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.routes.compute.ts Session-bind /api/route and /api/overpass 2026-04-21 22:18:45 +02:00
api.v1.routes.test.ts fix: enforce Terms gate on bearer-token API requests 2026-05-08 01:59:28 +02:00
api.v1.test.ts Add unit tests for REST API validation and pagination 2026-04-13 00:58:18 +02:00
api.v1.uploads.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.well-known.trails-cool.test.ts Implement OAuth2 PKCE auth, discovery, and mobile API client 2026-04-13 00:41:40 +02:00
api.well-known.trails-cool.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
auth.accept-terms.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
auth.accept-terms.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
auth.login.tsx Implement completeAuth chokepoint + caller migration 2026-05-08 02:38:15 +02:00
auth.logout.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
auth.register.tsx Implement completeAuth chokepoint + caller migration 2026-05-08 02:38:15 +02:00
auth.verify.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
auth.verify.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
explore.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
explore.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
feed.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
feed.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
follows.requests.tsx Merge /follows/requests into /notifications as a tabbed inbox 2026-04-26 08:24:59 +02:00
home.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
home.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
legal.imprint.tsx Apply minimal legal-review follow-ups 2026-04-19 07:27:56 +02:00
legal.privacy.tsx Add Komoot import with public (bio verification) and authenticated modes 2026-05-23 10:18:46 +02:00
legal.terms.tsx Store Terms version alongside acceptance timestamp 2026-04-19 07:46:34 +02:00
notifications.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
notifications.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
oauth.authorize.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
oauth.token.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
privacy.tsx Add legal pages, ToS acceptance, and alpha banner 2026-04-18 00:08:48 +02:00
routes.$id.edit.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes.$id.edit.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes.$id.server.ts fix(journal): remove ineffective dynamic imports 2026-05-24 12:05:08 +02:00
routes.$id.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes._index.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes._index.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes.new.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
routes.new.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings._index.tsx Split /settings into 4 sub-pages with a sidebar layout 2026-04-26 09:48:00 +02:00
settings.account.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.account.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.connections.komoot.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.connections.komoot.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.connections.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
settings.connections.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
settings.profile.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.profile.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.security.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.security.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
settings.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
sync.import.$provider.server.ts chore(ts): eliminate the remaining 4 \as any\ casts in production code 2026-05-26 07:11:02 +02:00
sync.import.$provider.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
sync.import.komoot.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
sync.import.komoot.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
users.$username.followers.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
users.$username.followers.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
users.$username.following.server.ts fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
users.$username.following.tsx fix(journal): extract loaders/actions for the remaining 21 mixed routes 2026-05-24 11:05:40 +02:00
users.$username.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
users.$username.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00