4de6c86d41
Addresses 8 issues from the Journal architecture audit: 1. DB indexes on routes.ownerId + activities.ownerId. Listing queries on these tables were full table scans; adds composite indexes matching the order-by columns (updatedAt/startedAt/createdAt). 2. Zod validation on /api/auth/register body. Previously the action destructured request.json() with zero schema validation. 3. N+1 GeoJSON batch fetch collapsed to a single ANY($1::text[]) query in both routes.server and activities.server. 4. Webhook envelope validation in /api/sync/webhook/:provider. 5. AbortSignal.timeout(30s) on all external fetches (Komoot, Wahoo) via a new fetchWithTimeout helper in lib/http.server.ts. 6. .limit(100) on listPublicRoutesForOwner / listPublicActivitiesForOwner. 9. Welcome email moved off fire-and-forget onto a pg-boss job with retryLimit: 3 (send-welcome-email). 10. process.env.ORIGIN ?? "http://localhost:3000" centralized into lib/config.server.ts::getOrigin() across 14 call sites. Issues 7 (centralized apiError/auth guards across 60+ route files) and 8 (split .server.ts boundaries across 20+ route files) intentionally deferred — both are pure refactors that would balloon this PR past reviewability and warrant their own focused PRs. Tests added: - lib/config.server.test.ts (2 cases) - lib/http.server.test.ts (3 cases — timeout abort, success passthrough, caller-signal composition) - routes/api.sync.webhook.$provider.test.ts (6 cases) - routes/api.auth.register.test.ts (7 cases — schema rejection paths + the new welcome-email enqueue assertion) Full repo: pnpm typecheck, pnpm lint, pnpm test all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
42 lines
1.5 KiB
TypeScript
42 lines
1.5 KiB
TypeScript
// POST /api/sync/komoot/verify
|
|
// Verifies Komoot public profile ownership by checking that the user's
|
|
// trails.cool profile URL appears in their Komoot bio.
|
|
// On success, creates or replaces the connected service row in public mode.
|
|
|
|
import { data, redirect } from "react-router";
|
|
import { getOrigin } from "~/lib/config.server";
|
|
import type { Route } from "./+types/api.sync.komoot.verify";
|
|
import { getSessionUser } from "~/lib/auth/session.server";
|
|
import { parseKomootUserId, verifyKomootOwnership } from "~/lib/komoot.server";
|
|
import { link } from "~/lib/connected-services/manager";
|
|
export async function action({ request }: Route.ActionArgs) {
|
|
const user = await getSessionUser(request);
|
|
if (!user) return redirect("/auth/login");
|
|
|
|
const body = (await request.json()) as { komootProfileUrl?: string };
|
|
const input = body.komootProfileUrl?.trim() ?? "";
|
|
|
|
const komootUserId = parseKomootUserId(input);
|
|
if (!komootUserId) {
|
|
return data({ error: "invalid_url" }, { status: 400 });
|
|
}
|
|
|
|
const origin = getOrigin();
|
|
const trailsProfileUrl = `${origin}/users/${user.username}`;
|
|
|
|
const verified = await verifyKomootOwnership(komootUserId, trailsProfileUrl);
|
|
if (!verified) {
|
|
return data({ error: "not_verified" }, { status: 422 });
|
|
}
|
|
|
|
await link({
|
|
userId: user.id,
|
|
provider: "komoot",
|
|
credentialKind: "public",
|
|
credentials: { mode: "public", komootUserId },
|
|
providerUserId: komootUserId,
|
|
grantedScopes: [],
|
|
});
|
|
|
|
return data({ success: true });
|
|
}
|