5a7bb76ff1
Adds `requireSecret(name, devFallback)` in lib/config.server.ts and `getDatabaseUrl()` in @trails-cool/db. Both: - return the env var when set, - fall back to the dev default in non-production, - throw at boot in production if the env var is missing OR matches the known dev fallback (which would otherwise silently ship a public secret / point at localhost). Applied to: - JWT_SECRET (lib/jwt.server.ts) — was `?? "dev-jwt-secret-change-in-production"` - SESSION_SECRET (lib/auth/session.server.ts) — was `?? "dev-secret-change-in-production"` - DATABASE_URL (server.ts health + boss; packages/db migrate-data) — was `?? "postgres://trails:trails@localhost:5432/trails"` Why: these strings are in the repo and known to attackers. A misconfigured prod deploy that forgot to set them would either run with guessable signing keys (full session/JWT forgery) or connect to a non-existent localhost DB. Better to refuse to start than to silently operate insecurely. Tests: - packages/db/src/get-database-url.test.ts (5 cases) - lib/config.server.test.ts gains `requireSecret` cases (4 new) Full repo: pnpm typecheck, pnpm lint, pnpm test all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
54 lines
1.9 KiB
TypeScript
54 lines
1.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
|
|
describe("getOrigin", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
});
|
|
|
|
it("returns ORIGIN env when set", async () => {
|
|
vi.stubEnv("ORIGIN", "https://example.com");
|
|
const { getOrigin } = await import("./config.server.ts");
|
|
expect(getOrigin()).toBe("https://example.com");
|
|
});
|
|
|
|
it("falls back to localhost when unset", async () => {
|
|
delete process.env.ORIGIN;
|
|
const { getOrigin } = await import("./config.server.ts");
|
|
expect(getOrigin()).toBe("http://localhost:3000");
|
|
});
|
|
});
|
|
|
|
describe("requireSecret", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
it("returns the env value when set in any environment", async () => {
|
|
vi.stubEnv("NODE_ENV", "production");
|
|
vi.stubEnv("MY_SECRET", "real-secret");
|
|
const { requireSecret } = await import("./config.server.ts");
|
|
expect(requireSecret("MY_SECRET", "dev-fallback")).toBe("real-secret");
|
|
});
|
|
|
|
it("returns the dev fallback when unset in development", async () => {
|
|
vi.stubEnv("NODE_ENV", "development");
|
|
delete process.env.MY_SECRET;
|
|
const { requireSecret } = await import("./config.server.ts");
|
|
expect(requireSecret("MY_SECRET", "dev-fallback")).toBe("dev-fallback");
|
|
});
|
|
|
|
it("throws in production when the secret is unset", async () => {
|
|
vi.stubEnv("NODE_ENV", "production");
|
|
delete process.env.MY_SECRET;
|
|
const { requireSecret } = await import("./config.server.ts");
|
|
expect(() => requireSecret("MY_SECRET", "dev-fallback")).toThrow(/MY_SECRET/);
|
|
});
|
|
|
|
it("throws in production when the secret matches the dev fallback", async () => {
|
|
vi.stubEnv("NODE_ENV", "production");
|
|
vi.stubEnv("MY_SECRET", "dev-fallback");
|
|
const { requireSecret } = await import("./config.server.ts");
|
|
expect(() => requireSecret("MY_SECRET", "dev-fallback")).toThrow(/dev fallback/);
|
|
});
|
|
});
|