5a7bb76ff1
Adds `requireSecret(name, devFallback)` in lib/config.server.ts and `getDatabaseUrl()` in @trails-cool/db. Both: - return the env var when set, - fall back to the dev default in non-production, - throw at boot in production if the env var is missing OR matches the known dev fallback (which would otherwise silently ship a public secret / point at localhost). Applied to: - JWT_SECRET (lib/jwt.server.ts) — was `?? "dev-jwt-secret-change-in-production"` - SESSION_SECRET (lib/auth/session.server.ts) — was `?? "dev-secret-change-in-production"` - DATABASE_URL (server.ts health + boss; packages/db migrate-data) — was `?? "postgres://trails:trails@localhost:5432/trails"` Why: these strings are in the repo and known to attackers. A misconfigured prod deploy that forgot to set them would either run with guessable signing keys (full session/JWT forgery) or connect to a non-existent localhost DB. Better to refuse to start than to silently operate insecurely. Tests: - packages/db/src/get-database-url.test.ts (5 cases) - lib/config.server.test.ts gains `requireSecret` cases (4 new) Full repo: pnpm typecheck, pnpm lint, pnpm test all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
32 lines
1.3 KiB
TypeScript
32 lines
1.3 KiB
TypeScript
// Centralized access to the canonical origin for this Journal instance.
|
|
// `ORIGIN` is set in production to the public HTTPS URL; in dev it falls
|
|
// back to http://localhost:3000. Use the helper everywhere so the default
|
|
// can be changed in one place if needed.
|
|
export function getOrigin(): string {
|
|
return process.env.ORIGIN ?? "http://localhost:3000";
|
|
}
|
|
|
|
/**
|
|
* Read a required secret from the environment. Returns the env value when
|
|
* set. In production, throws if the env var is missing or matches the
|
|
* known-public dev fallback — silently shipping a default secret to prod
|
|
* is a credential leak. In dev/test, returns the supplied fallback so the
|
|
* local loop keeps working without ceremony.
|
|
*
|
|
* Use this for any value where a leaked default would be a security
|
|
* incident: signing keys, session secrets, database credentials.
|
|
*/
|
|
export function requireSecret(name: string, devFallback: string): string {
|
|
const value = process.env[name];
|
|
const isProd = process.env.NODE_ENV === "production";
|
|
if (isProd) {
|
|
if (!value || value === devFallback) {
|
|
throw new Error(
|
|
`Refusing to start: ${name} is unset or matches the known-public dev fallback. ` +
|
|
`Set ${name} to a strong, unique value in production.`,
|
|
);
|
|
}
|
|
return value;
|
|
}
|
|
return value ?? devFallback;
|
|
}
|