78b8b8f55f
Eliminates the silent-failure pattern where a route/activity row could be committed with gpx IS NOT NULL but geom IS NULL if the PostGIS write failed after the row insert. - New gpx-save.server.ts owns all GPX validation (GpxValidationError, validateGpx) and PostGIS geometry writes (writeGeom, tx-aware) - createRoute, updateRoute, createActivity, createRouteFromActivity all wrapped in db.transaction() covering row + geom + version snapshot - demo-bot uses createRoute/createActivity instead of raw inserts; errors propagate loudly - Callback endpoint returns 400 for GpxValidationError instead of 401 - ADR-0006 documents the invariant for future explorers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { validateGpx, GpxValidationError } from "./gpx-save.server.ts";
|
|
|
|
const VALID_GPX = `<?xml version="1.0" encoding="UTF-8"?>
|
|
<gpx version="1.1" xmlns="http://www.topografix.com/GPX/1/1">
|
|
<trk>
|
|
<trkseg>
|
|
<trkpt lat="47.0" lon="8.0"><ele>500</ele></trkpt>
|
|
<trkpt lat="47.1" lon="8.1"><ele>520</ele></trkpt>
|
|
<trkpt lat="47.2" lon="8.2"><ele>510</ele></trkpt>
|
|
</trkseg>
|
|
</trk>
|
|
</gpx>`;
|
|
|
|
const ONE_POINT_GPX = `<?xml version="1.0" encoding="UTF-8"?>
|
|
<gpx version="1.1" xmlns="http://www.topografix.com/GPX/1/1">
|
|
<trk>
|
|
<trkseg>
|
|
<trkpt lat="47.0" lon="8.0"><ele>500</ele></trkpt>
|
|
</trkseg>
|
|
</trk>
|
|
</gpx>`;
|
|
|
|
const EMPTY_GPX = `<?xml version="1.0" encoding="UTF-8"?>
|
|
<gpx version="1.1" xmlns="http://www.topografix.com/GPX/1/1">
|
|
<trk><trkseg></trkseg></trk>
|
|
</gpx>`;
|
|
|
|
const OUT_OF_RANGE_LAT_GPX = `<?xml version="1.0" encoding="UTF-8"?>
|
|
<gpx version="1.1" xmlns="http://www.topografix.com/GPX/1/1">
|
|
<trk>
|
|
<trkseg>
|
|
<trkpt lat="91.0" lon="8.0"></trkpt>
|
|
<trkpt lat="47.0" lon="8.0"></trkpt>
|
|
</trkseg>
|
|
</trk>
|
|
</gpx>`;
|
|
|
|
const OUT_OF_RANGE_LON_GPX = `<?xml version="1.0" encoding="UTF-8"?>
|
|
<gpx version="1.1" xmlns="http://www.topografix.com/GPX/1/1">
|
|
<trk>
|
|
<trkseg>
|
|
<trkpt lat="47.0" lon="181.0"></trkpt>
|
|
<trkpt lat="47.1" lon="8.0"></trkpt>
|
|
</trkseg>
|
|
</trk>
|
|
</gpx>`;
|
|
|
|
describe("validateGpx", () => {
|
|
it("returns parsed GpxData for valid GPX", async () => {
|
|
const result = await validateGpx(VALID_GPX);
|
|
expect(result.tracks.flat().length).toBe(3);
|
|
expect(result.tracks[0]![0]!.lat).toBeCloseTo(47.0);
|
|
});
|
|
|
|
it("throws GpxValidationError for GPX with fewer than 2 track points", async () => {
|
|
await expect(validateGpx(ONE_POINT_GPX)).rejects.toThrow(GpxValidationError);
|
|
await expect(validateGpx(ONE_POINT_GPX)).rejects.toThrow("at least 2 track points");
|
|
});
|
|
|
|
it("throws GpxValidationError for GPX with zero track points", async () => {
|
|
await expect(validateGpx(EMPTY_GPX)).rejects.toThrow(GpxValidationError);
|
|
await expect(validateGpx(EMPTY_GPX)).rejects.toThrow("at least 2 track points");
|
|
});
|
|
|
|
it("throws GpxValidationError for out-of-range latitude", async () => {
|
|
await expect(validateGpx(OUT_OF_RANGE_LAT_GPX)).rejects.toThrow(GpxValidationError);
|
|
await expect(validateGpx(OUT_OF_RANGE_LAT_GPX)).rejects.toThrow("out-of-range coordinates");
|
|
});
|
|
|
|
it("throws GpxValidationError for out-of-range longitude", async () => {
|
|
await expect(validateGpx(OUT_OF_RANGE_LON_GPX)).rejects.toThrow(GpxValidationError);
|
|
await expect(validateGpx(OUT_OF_RANGE_LON_GPX)).rejects.toThrow("out-of-range coordinates");
|
|
});
|
|
|
|
it("throws GpxValidationError for unparseable XML", async () => {
|
|
await expect(validateGpx("not xml at all")).rejects.toThrow(GpxValidationError);
|
|
await expect(validateGpx("<broken<xml")).rejects.toThrow(GpxValidationError);
|
|
});
|
|
|
|
it("GpxValidationError has the correct name", async () => {
|
|
const err = await validateGpx(EMPTY_GPX).catch((e) => e);
|
|
expect(err).toBeInstanceOf(GpxValidationError);
|
|
expect(err.name).toBe("GpxValidationError");
|
|
});
|
|
});
|