trails/apps/journal/app/lib/demo-bot.integration.test.ts
Ullrich Schäfer ded70a5404
ci: wire integration tests into the CI E2E job
The five \`*.integration.test.ts\` files in apps/journal (explore, follow,
demo-bot, notifications, notifications-fanout — 31 tests total) were
gated behind \`EXPLORE_INTEGRATION=1\` / \`FOLLOW_INTEGRATION=1\` /
\`DEMO_BOT_INTEGRATION=1\` / \`NOTIFICATIONS_INTEGRATION=1\`. The unit-test
job doesn't have Postgres, so they correctly skipped there — but no
CI job set the env vars, so they were effectively dead code.

Added a step in the E2E job (which already has Postgres + schema
pushed) that flips all four gates and runs the integration files
serially (\`--no-file-parallelism\` — they share the schema and trip FK
constraints if run in parallel; ~2.5s sequential anyway).

Wiring them up surfaced two real issues, both fixed here:

1. **\`createRoute\` silently dropped \`input.visibility\`** — every
   caller passing \`visibility: \"public\"\` (including the demo-bot)
   was getting the column's \`private\` default. Spread now mirrors
   \`createActivity\`'s pattern. Demo-bot routes have actually been
   private in production all this time — they were rendering on the
   home feed only via the \`activity_published\` fan-out from the
   *activity*, not as visible *routes*.

2. **The demo-bot test's fetch stub was incomplete** — it stubbed
   \`.text()\` but the planner-session preflight calls \`.json()\`. The
   stub now branches on URL: \`/api/sessions\` returns
   \`{ sessionId: 'test-session' }\` JSON, the BRouter call returns the
   stub GPX text.

Full repo: pnpm typecheck, pnpm lint, pnpm test all green
(177 unit-test pass + 31 integration pass = 208 total, no skips).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-25 23:27:44 +02:00

166 lines
6.1 KiB
TypeScript

import { describe, it, expect, beforeAll, afterEach, vi } from "vitest";
import { sql } from "drizzle-orm";
import { getDb } from "./db.ts";
import { activities, routes, users } from "@trails-cool/db/schema/journal";
import {
DEFAULT_PERSONA,
DemoPersonaUsernameClashError,
__resetPersonaCacheForTests,
ensureDemoUser,
generateOneWalk,
pruneSynthetic,
} from "./demo-bot.server.ts";
import { randomUUID } from "node:crypto";
// Opt-in: these tests talk to a real Postgres and are skipped unless
// `DEMO_BOT_INTEGRATION=1` is set. CI gates them behind the same flag
// so we don't break laptop runs that have no Postgres up.
const runIntegration = process.env.DEMO_BOT_INTEGRATION === "1";
// A tiny valid GPX that parseGpxAsync can chew on. Two trkpts in Berlin,
// ~2 km apart — enough to pass the 500 m min-distance gate in
// generateOneWalk.
const STUB_GPX = `<?xml version="1.0" encoding="UTF-8"?>
<gpx version="1.1" creator="demo-bot-test" xmlns="http://www.topografix.com/GPX/1/1">
<trk><trkseg>
<trkpt lat="52.5200" lon="13.4050"><ele>34</ele></trkpt>
<trkpt lat="52.5300" lon="13.4200"><ele>38</ele></trkpt>
<trkpt lat="52.5400" lon="13.4350"><ele>40</ele></trkpt>
</trkseg></trk>
</gpx>`;
async function wipeSynthetic() {
const db = getDb();
await db.execute(sql`DELETE FROM journal.activities WHERE synthetic = true`);
await db.execute(sql`DELETE FROM journal.routes WHERE synthetic = true`);
}
describe.skipIf(!runIntegration)("demo-bot integration", () => {
beforeAll(async () => {
// Sanity: make sure we can reach the DB and synthetic column exists.
const db = getDb();
await db.execute(sql`SELECT 1 FROM journal.routes WHERE synthetic IS NOT NULL LIMIT 0`);
});
afterEach(async () => {
await wipeSynthetic();
// Scrub any test-inserted Bruno so the next test starts clean.
const db = getDb();
await db.execute(sql`DELETE FROM journal.users WHERE username = ${DEFAULT_PERSONA.username}`);
__resetPersonaCacheForTests();
vi.restoreAllMocks();
});
it("ensureDemoUser is idempotent", async () => {
const id1 = await ensureDemoUser();
const id2 = await ensureDemoUser();
expect(id1).toBe(id2);
const db = getDb();
const rows = await db
.select()
.from(users)
.where(sql`${users.username} = ${DEFAULT_PERSONA.username}`);
expect(rows.length).toBe(1);
});
it("ensureDemoUser throws username-clash when a real user owns the persona name", async () => {
const db = getDb();
const domain = process.env.DOMAIN ?? "localhost";
const realUserId = randomUUID();
// Create a real user at the persona username with a NON-sentinel email.
await db.execute(sql`
INSERT INTO journal.users (id, email, username, domain, terms_accepted_at, terms_version)
VALUES (${realUserId}, ${`real-${Date.now()}@${domain}`}, ${DEFAULT_PERSONA.username}, ${domain}, now(), '2026-04-19')
`);
try {
await expect(ensureDemoUser()).rejects.toBeInstanceOf(DemoPersonaUsernameClashError);
} finally {
await db.execute(sql`DELETE FROM journal.users WHERE id = ${realUserId}`);
}
});
it("generateOneWalk inserts a public synthetic route + activity", async () => {
// createPlannerSession() calls resp.json() (returns { sessionId });
// requestBrouterGpx() then calls resp.text() (returns the GPX body).
// Stub both so the chain completes without a real Planner running.
vi.stubGlobal(
"fetch",
vi.fn().mockImplementation((input: string | URL) => {
const url = typeof input === "string" ? input : input.toString();
if (url.endsWith("/api/sessions")) {
return Promise.resolve({
ok: true,
status: 200,
json: async () => ({ sessionId: "test-session" }),
});
}
return Promise.resolve({
ok: true,
status: 200,
text: async () => STUB_GPX,
});
}),
);
const ownerId = await ensureDemoUser();
const routeId = await generateOneWalk(ownerId);
expect(routeId).toBeTruthy();
const db = getDb();
const [route] = await db
.select()
.from(routes)
.where(sql`${routes.id} = ${routeId!}`);
expect(route?.synthetic).toBe(true);
expect(route?.visibility).toBe("public");
expect(route?.routingProfile).toBe("trekking");
expect(route?.ownerId).toBe(ownerId);
const acts = await db
.select()
.from(activities)
.where(sql`${activities.routeId} = ${routeId!}`);
expect(acts.length).toBe(1);
expect(acts[0]?.synthetic).toBe(true);
expect(acts[0]?.visibility).toBe("public");
expect(acts[0]?.duration).toBeGreaterThan(0);
});
it("pruneSynthetic only removes synthetic rows past the window", async () => {
const ownerId = await ensureDemoUser();
const db = getDb();
// One synthetic route that is 30 days old, one that is fresh.
await db.execute(sql`
INSERT INTO journal.routes
(id, owner_id, name, synthetic, visibility, created_at, updated_at)
VALUES
(gen_random_uuid()::text, ${ownerId}, 'old-synth', true, 'public', now() - interval '30 days', now() - interval '30 days'),
(gen_random_uuid()::text, ${ownerId}, 'fresh-synth', true, 'public', now(), now())
`);
// A non-synthetic route that is also 30 days old — must be kept.
await db.execute(sql`
INSERT INTO journal.routes
(id, owner_id, name, synthetic, visibility, created_at, updated_at)
VALUES
(gen_random_uuid()::text, ${ownerId}, 'old-real', false, 'private', now() - interval '30 days', now() - interval '30 days')
`);
const counts = await pruneSynthetic(14);
expect(counts.routes).toBe(1);
const remaining = await db
.select({ name: routes.name, synthetic: routes.synthetic })
.from(routes)
.where(sql`${routes.ownerId} = ${ownerId} AND ${routes.name} IN ('old-synth','fresh-synth','old-real')`);
const names = remaining.map((r) => r.name).sort();
expect(names).toEqual(["fresh-synth", "old-real"]);
// Clean up the non-synthetic test row
await db.execute(sql`DELETE FROM journal.routes WHERE owner_id = ${ownerId} AND name = 'old-real'`);
});
});