trails/e2e/settings.test.ts
Ullrich Schäfer 4e2bfb0bbe Redesign navbar with avatar dropdown and mobile drawer
Stream C from docs/information-architecture.md. The navbar's account
cluster (<username> + Settings + Logout) was three controls for the
same concept; the cluster now collapses behind an avatar dropdown.
On mobile, all primary nav and account controls move into a
hamburger drawer so the top bar stays at logo + bell + hamburger
without wrapping at small viewports.

- New apps/journal/app/components/Avatar.tsx — initials-only avatar
  (no image-upload story yet; the component is the single place to
  add image fallback when one lands).
- New apps/journal/app/components/AccountDropdown.tsx — click the
  avatar trigger to reveal Profile / Settings / Log Out menuitems.
  Click-outside + Escape-to-close. role="menu" + role="menuitem" for
  a11y.
- New apps/journal/app/components/MobileNavMenu.tsx — hamburger
  trigger + slide-out drawer at md and below. Contains all primary
  nav (Feed, Explore, Routes, Activities, Notifications) plus the
  account cluster (Profile, Settings, Log Out). Auto-closes on
  navigation; locks body scroll while open.
- apps/journal/app/root.tsx — refactor NavBar:
  * Brand + primary nav links hide at md and below (drawer covers
    them).
  * Right cluster: bell on every viewport; avatar dropdown on
    desktop, hamburger on mobile.
  * Loader exposes user.displayName so Avatar can compute initials.
  * Drops the now-unused Form import; Form moved into the
    dropdown/drawer components.

E2E tests updated:
- e2e/auth.test.ts — logout helper opens the avatar dropdown via
  aria-label = displayName||username, then clicks the Log Out
  menuitem. Username assertions in nav switch from getByText to
  getByRole("button", {name: username}) (the avatar button).
- e2e/settings.test.ts — "settings link visible in nav" opens the
  avatar dropdown first, then asserts the Settings menuitem.

i18n: nav.openMenu, nav.closeMenu keys for the hamburger trigger
labels (EN + DE).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-26 09:56:20 +02:00

188 lines
7.2 KiB
TypeScript

import { test, expect, type CDPSession, type Page } from "./fixtures/test";
async function setupVirtualAuthenticator(cdp: CDPSession) {
await cdp.send("WebAuthn.enable");
const { authenticatorId } = await cdp.send("WebAuthn.addVirtualAuthenticator", {
options: {
protocol: "ctap2",
transport: "internal",
hasResidentKey: true,
hasUserVerification: true,
isUserVerified: true,
},
});
return authenticatorId;
}
async function removeVirtualAuthenticator(cdp: CDPSession, authenticatorId: string) {
await cdp.send("WebAuthn.removeVirtualAuthenticator", { authenticatorId });
await cdp.send("WebAuthn.disable");
}
async function registerAndLogin(page: Page, cdp: CDPSession) {
const email = `settings-${Date.now()}@example.com`;
const username = `settingsuser${Date.now()}`;
await page.goto("/auth/register");
await page.getByLabel("Email").fill(email);
await page.getByLabel("Username").fill(username);
await page.getByRole("button", { name: /Register with Passkey/ }).click();
await expect(page).toHaveURL("/", { timeout: 10000 });
return { email, username };
}
test.describe("Account Settings", () => {
test("unauthenticated user is redirected to login", async ({ page }) => {
await page.goto("/settings");
await expect(page).toHaveURL(/\/auth\/login/, { timeout: 5000 });
});
test("settings page loads for authenticated user", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
await registerAndLogin(page, cdp);
await page.goto("/settings");
await expect(page.getByRole("heading", { name: "Settings" })).toBeVisible();
await expect(page.getByText("Profile")).toBeVisible();
await expect(page.getByText("Security")).toBeVisible();
await expect(page.getByText("Account")).toBeVisible();
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("update display name and bio", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
const { username } = await registerAndLogin(page, cdp);
await page.goto("/settings");
await page.getByLabel("Display Name").fill("Test Display Name");
await page.getByLabel("Bio").fill("I love hiking!");
await page.getByRole("button", { name: "Save" }).click();
await expect(page.getByText("Profile saved")).toBeVisible({ timeout: 5000 });
// Reload and verify persistence
await page.reload();
await expect(page.getByLabel("Display Name")).toHaveValue("Test Display Name");
await expect(page.getByLabel("Bio")).toHaveValue("I love hiking!");
// Verify public profile reflects changes
await page.goto(`/users/${username}`);
await expect(page.getByText("Test Display Name")).toBeVisible();
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("passkey list shows registered passkey", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
await registerAndLogin(page, cdp);
await page.goto("/settings");
// Should show the passkey registered during registration
await expect(page.getByText("This device")).toBeVisible();
await expect(page.getByText(/Added/)).toBeVisible();
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("add and delete passkey from settings", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
await registerAndLogin(page, cdp);
await page.goto("/settings");
// Should have 1 passkey from registration
const deleteButtons = page.getByRole("button", { name: "Delete" });
await expect(deleteButtons).toHaveCount(1);
// Add another passkey
await page.getByRole("button", { name: "Add Passkey" }).click();
await page.waitForTimeout(1000);
// After reload, should have 2 passkeys
await expect(deleteButtons).toHaveCount(2, { timeout: 5000 });
// Delete one
page.on("dialog", (dialog) => dialog.accept());
await deleteButtons.first().click();
await expect(page).toHaveURL(/\/settings/, { timeout: 5000 });
await expect(page.getByRole("button", { name: "Delete" })).toHaveCount(1);
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("delete last passkey shows warning", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
await registerAndLogin(page, cdp);
await page.goto("/settings");
// Intercept the confirm dialog to check it contains the warning
let dialogMessage = "";
page.on("dialog", async (dialog) => {
dialogMessage = dialog.message();
await dialog.accept();
});
await page.getByRole("button", { name: "Delete" }).click();
expect(dialogMessage).toContain("only passkey");
// After deleting, should show "No passkeys registered"
await expect(page.getByText(/No passkeys registered/)).toBeVisible({ timeout: 5000 });
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("settings link reachable from nav when logged in", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
const { username } = await registerAndLogin(page, cdp);
// Settings now lives inside the avatar dropdown; opening the
// dropdown reveals the menuitem.
await page.getByRole("navigation").getByRole("button", { name: username }).click();
await expect(page.getByRole("menuitem", { name: "Settings" })).toBeVisible();
await removeVirtualAuthenticator(cdp, authenticatorId);
});
test("settings link not visible when logged out", async ({ page }) => {
await page.goto("/");
// Anonymous navbar has neither the avatar nor the Settings link.
await expect(page.getByRole("navigation").getByRole("link", { name: "Settings" })).not.toBeVisible();
});
test("account deletion requires correct username", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);
const { username } = await registerAndLogin(page, cdp);
await page.goto("/settings");
// Click delete account
await page.getByRole("button", { name: "Delete Account" }).click();
// Type wrong username — button should be disabled
await page.getByPlaceholder(username).fill("wrongname");
await expect(page.getByRole("button", { name: "Permanently Delete" })).toBeDisabled();
// Type correct username — button should be enabled
await page.getByPlaceholder(username).fill(username);
await expect(page.getByRole("button", { name: "Permanently Delete" })).toBeEnabled();
// Submit deletion
await page.getByRole("button", { name: "Permanently Delete" }).click();
await expect(page).toHaveURL("/", { timeout: 10000 });
// Session should be destroyed — nav should show login
await expect(page.getByRole("navigation").getByRole("link", { name: "Sign In" })).toBeVisible({ timeout: 5000 });
await removeVirtualAuthenticator(cdp, authenticatorId);
});
});