Two issues caused the same class of flake locally: 1. Default workers were CPU-count, but the journal/planner are served by Vite dev (not the production build CI uses). Cold-compiling `/api/auth/register` under N parallel hits produced 30s timeouts on a quarter of runs. Set workers to 1 in both environments for parity with CI. 2. Even sequentially, a button is clickable per Playwright's actionability check before React has hydrated its `onClick`. So the first click after a navigation could fire native form submit (or do nothing), which manifested as "URL never changed to /" or "menuitem Log Out never appeared". Add a `waitForHydration` helper that polls for React fibers (`__reactProps$<id>`) attached to a DOM node and call it after each cross-page navigation that ends in an interactive form or dropdown. CI is unaffected (production builds hydrate fast and didn't expose either bug), but the helper is harmless there. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
124 lines
5 KiB
TypeScript
124 lines
5 KiB
TypeScript
import { test, expect, waitForHydration, type CDPSession, type Page } from "./fixtures/test";
|
|
|
|
// Virtual authenticator helpers
|
|
async function setupVirtualAuthenticator(cdp: CDPSession) {
|
|
await cdp.send("WebAuthn.enable");
|
|
const { authenticatorId } = await cdp.send("WebAuthn.addVirtualAuthenticator", {
|
|
options: {
|
|
protocol: "ctap2",
|
|
transport: "internal",
|
|
hasResidentKey: true,
|
|
hasUserVerification: true,
|
|
isUserVerified: true,
|
|
},
|
|
});
|
|
return authenticatorId;
|
|
}
|
|
|
|
async function removeVirtualAuthenticator(cdp: CDPSession, authenticatorId: string) {
|
|
await cdp.send("WebAuthn.removeVirtualAuthenticator", { authenticatorId });
|
|
await cdp.send("WebAuthn.disable");
|
|
}
|
|
|
|
async function registerUser(page: Page, email: string, username: string) {
|
|
await page.goto("/auth/register");
|
|
await expect(page.getByRole("heading", { name: "Register" })).toBeVisible();
|
|
await waitForHydration(page);
|
|
await page.getByLabel("Email").click();
|
|
await page.getByLabel("Email").fill(email);
|
|
await page.getByLabel("Username").click();
|
|
await page.getByLabel("Username").fill(username);
|
|
// Verify both fields retained values before submitting
|
|
await expect(page.getByLabel("Email")).toHaveValue(email);
|
|
await expect(page.getByLabel("Username")).toHaveValue(username);
|
|
// Accept the Terms of Service (required)
|
|
await page.getByRole("checkbox").check();
|
|
await page.getByRole("button", { name: /Register with Passkey/ }).click();
|
|
}
|
|
|
|
async function logout(page: Page, accountLabel: string) {
|
|
// The account cluster lives inside an avatar dropdown now. Click the
|
|
// avatar (its aria-label is displayName || username), then click the
|
|
// Log Out menuitem inside the popup.
|
|
await waitForHydration(page);
|
|
await page.getByRole("navigation").getByRole("button", { name: accountLabel }).click();
|
|
await page.getByRole("menuitem", { name: "Log Out" }).click();
|
|
await expect(page.getByRole("navigation").getByRole("link", { name: "Sign In" })).toBeVisible({ timeout: 5000 });
|
|
}
|
|
|
|
test.describe("Passkey Authentication", () => {
|
|
test("register with passkey and sign in", async ({ page }) => {
|
|
const cdp = await page.context().newCDPSession(page);
|
|
const authenticatorId = await setupVirtualAuthenticator(cdp);
|
|
|
|
const email = `test-${Date.now()}@example.com`;
|
|
const username = `testuser${Date.now()}`;
|
|
|
|
// Register
|
|
await registerUser(page, email, username);
|
|
await expect(page).toHaveURL("/", { timeout: 10000 });
|
|
// The avatar button's aria-label is the displayName or username;
|
|
// for a freshly-registered user with no displayName set, that's
|
|
// the username.
|
|
await expect(page.getByRole("navigation").getByRole("button", { name: username })).toBeVisible({ timeout: 5000 });
|
|
|
|
// Log out
|
|
await logout(page, username);
|
|
|
|
// Sign in with passkey
|
|
await page.goto("/auth/login");
|
|
await page.getByRole("button", { name: /Sign in with Passkey/ }).click();
|
|
await expect(page).toHaveURL("/", { timeout: 10000 });
|
|
await expect(page.getByRole("navigation").getByRole("button", { name: username })).toBeVisible({ timeout: 5000 });
|
|
|
|
await removeVirtualAuthenticator(cdp, authenticatorId);
|
|
});
|
|
|
|
test("passkey login fails with no registered credential", async ({ page }) => {
|
|
const cdp = await page.context().newCDPSession(page);
|
|
const authenticatorId = await setupVirtualAuthenticator(cdp);
|
|
|
|
await page.goto("/auth/login");
|
|
await page.getByRole("button", { name: /Sign in with Passkey/ }).click();
|
|
await expect(page.getByText(/No passkey found/i)).toBeVisible({ timeout: 10000 });
|
|
|
|
await removeVirtualAuthenticator(cdp, authenticatorId);
|
|
});
|
|
|
|
test("register rejects duplicate email", async ({ page }) => {
|
|
const cdp = await page.context().newCDPSession(page);
|
|
const authenticatorId = await setupVirtualAuthenticator(cdp);
|
|
|
|
const email = `dup-${Date.now()}@example.com`;
|
|
const firstUsername = `first${Date.now()}`;
|
|
|
|
// Register first user
|
|
await registerUser(page, email, firstUsername);
|
|
await expect(page).toHaveURL("/", { timeout: 10000 });
|
|
await logout(page, firstUsername);
|
|
|
|
// Try to register with same email
|
|
await registerUser(page, email, `second${Date.now()}`);
|
|
await expect(page.getByText(/already in use/i)).toBeVisible({ timeout: 10000 });
|
|
|
|
await removeVirtualAuthenticator(cdp, authenticatorId);
|
|
});
|
|
|
|
test("register rejects duplicate username", async ({ page }) => {
|
|
const cdp = await page.context().newCDPSession(page);
|
|
const authenticatorId = await setupVirtualAuthenticator(cdp);
|
|
|
|
const username = `uniq${Date.now()}`;
|
|
|
|
// Register first user
|
|
await registerUser(page, `first-${Date.now()}@example.com`, username);
|
|
await expect(page).toHaveURL("/", { timeout: 10000 });
|
|
await logout(page, username);
|
|
|
|
// Try to register with same username
|
|
await registerUser(page, `second-${Date.now()}@example.com`, username);
|
|
await expect(page.getByText(/already taken/i)).toBeVisible({ timeout: 10000 });
|
|
|
|
await removeVirtualAuthenticator(cdp, authenticatorId);
|
|
});
|
|
});
|