trails/e2e/integration.test.ts
Ullrich Schäfer f94020a93a
Block unmocked external requests in E2E tests
Surface net for the class of bug we hit in #282 — a POI test silently
relied on a live Overpass server for months because its `page.route`
mock was targeting a URL the browser no longer hit directly. CI stayed
green on coincidence (real OSM data happened to satisfy the "any
marker renders" assertion) until upstream behaviour drifted.

Add a shared Playwright fixture (e2e/fixtures/test.ts) that installs a
catch-all `page.route("**", ...)` before each test. Requests to
localhost + known tile CDNs pass through via `route.continue()`;
anything else is aborted and accumulated. At test teardown, a non-empty
blocked list throws, failing the test with the offending URLs and a
pointer to the fixture.

All seven e2e *.test.ts files updated to import test/expect (+ types)
from ./fixtures/test.

Full suite passes with this fixture in place (50/50 at --workers=2;
catch-all never fires, meaning no test currently relies on an
unallowlisted external service).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 22:42:29 +02:00

173 lines
5.9 KiB
TypeScript

import { test, expect } from "./fixtures/test";
/**
* Integration tests that require the full dev stack:
* - PostgreSQL (for sessions)
* - BRouter (for route computation)
*
* In CI, these services are started by the workflow.
* Locally, run `pnpm dev:full` first.
*/
const PLANNER = "http://localhost:3001";
test.describe("Integration: Journal ↔ Planner handoff", () => {
test("GPX import → view route → export GPX", async ({ request }) => {
const gpx = `<?xml version="1.0" encoding="UTF-8"?>
<gpx version="1.1" creator="test" xmlns="http://www.topografix.com/GPX/1/1">
<wpt lat="52.52" lon="13.405"><name>Berlin</name></wpt>
<wpt lat="52.50" lon="13.35"><name>Tiergarten</name></wpt>
<trk><trkseg>
<trkpt lat="52.52" lon="13.405"><ele>34</ele></trkpt>
<trkpt lat="52.51" lon="13.38"><ele>40</ele></trkpt>
<trkpt lat="52.50" lon="13.35"><ele>35</ele></trkpt>
</trkseg></trk>
</gpx>`;
const sessionResp = await request.post(`${PLANNER}/api/sessions`, {
data: { gpx },
});
expect(sessionResp.ok()).toBeTruthy();
const session = await sessionResp.json();
expect(session.initialWaypoints).toHaveLength(2);
expect(session.initialWaypoints[0].name).toBe("Berlin");
});
test("GPX import with overnight waypoints preserves isDayBreak", async ({ request }) => {
const gpx = `<?xml version="1.0" encoding="UTF-8"?>
<gpx version="1.1" creator="test" xmlns="http://www.topografix.com/GPX/1/1">
<wpt lat="52.52" lon="13.405"><name>Berlin</name></wpt>
<wpt lat="51.84" lon="12.243"><name>Dessau</name><type>overnight</type></wpt>
<wpt lat="50.98" lon="11.028"><name>Erfurt</name></wpt>
<trk><trkseg>
<trkpt lat="52.52" lon="13.405"><ele>34</ele></trkpt>
<trkpt lat="51.84" lon="12.243"><ele>80</ele></trkpt>
<trkpt lat="50.98" lon="11.028"><ele>195</ele></trkpt>
</trkseg></trk>
</gpx>`;
const sessionResp = await request.post(`${PLANNER}/api/sessions`, {
data: { gpx },
});
expect(sessionResp.ok()).toBeTruthy();
const session = await sessionResp.json();
expect(session.initialWaypoints).toHaveLength(3);
expect(session.initialWaypoints[1].name).toBe("Dessau");
// isDayBreak should be preserved through GPX parsing
expect(session.initialWaypoints[1].isDayBreak).toBe(true);
});
});
test.describe("Integration: BRouter routing", () => {
test("computes route between Berlin waypoints", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [
{ lat: 52.516, lon: 13.377 },
{ lat: 52.515, lon: 13.351 },
],
profile: "trekking",
},
});
expect(response.ok()).toBeTruthy();
const enriched = await response.json();
expect(enriched.geojson.features).toHaveLength(1);
expect(enriched.geojson.features[0].geometry.type).toBe("LineString");
expect(enriched.coordinates.length).toBeGreaterThan(10);
});
test("routes through all waypoints (segment by segment)", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [
{ lat: 52.520, lon: 13.405 },
{ lat: 52.516, lon: 13.377 },
{ lat: 52.510, lon: 13.390 },
],
profile: "trekking",
},
});
expect(response.ok()).toBeTruthy();
const enriched = await response.json();
const coords = enriched.coordinates;
const nearMiddle = coords.some(
(c: number[]) =>
Math.abs(c[1] - 52.516) < 0.005 && Math.abs(c[0] - 13.377) < 0.005,
);
expect(nearMiddle).toBeTruthy();
});
test("returns rate limit headers", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [
{ lat: 52.516, lon: 13.377 },
{ lat: 52.515, lon: 13.351 },
],
},
});
expect(response.headers()["x-ratelimit-remaining"]).toBeDefined();
});
test("rejects with fewer than 2 waypoints", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [{ lat: 52.516, lon: 13.377 }],
},
});
expect(response.status()).toBe(400);
});
test("returns enriched route with segment boundaries", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [
{ lat: 52.520, lon: 13.405 },
{ lat: 52.516, lon: 13.377 },
{ lat: 52.510, lon: 13.390 },
],
profile: "trekking",
},
});
expect(response.ok()).toBeTruthy();
const enriched = await response.json();
// EnrichedRoute fields
expect(enriched.coordinates).toBeDefined();
expect(enriched.coordinates.length).toBeGreaterThan(10);
expect(enriched.coordinates[0]).toHaveLength(3); // [lon, lat, ele]
expect(enriched.segmentBoundaries).toBeDefined();
expect(enriched.segmentBoundaries).toHaveLength(2); // 3 waypoints = 2 segments
expect(enriched.segmentBoundaries[0]).toBe(0);
expect(enriched.totalLength).toBeGreaterThan(0);
expect(enriched.geojson).toBeDefined();
expect(enriched.geojson.features[0].geometry.type).toBe("LineString");
});
test("accepts no-go areas parameter", async ({ request }) => {
const response = await request.post(`${PLANNER}/api/route`, {
data: {
waypoints: [
{ lat: 52.516, lon: 13.377 },
{ lat: 52.515, lon: 13.351 },
],
profile: "trekking",
noGoAreas: [
{
points: [
{ lat: 52.516, lon: 13.365 },
{ lat: 52.514, lon: 13.365 },
{ lat: 52.514, lon: 13.370 },
{ lat: 52.516, lon: 13.370 },
],
},
],
},
});
expect(response.ok()).toBeTruthy();
const enriched = await response.json();
expect(enriched.geojson.features).toHaveLength(1);
expect(enriched.geojson.features[0].geometry.type).toBe("LineString");
});
});