trails/apps/journal/app/lib/auth.server.ts
Ullrich Schäfer 5905cdadea
Apply public-content-visibility: visibility flag + public profile
Implements the public-content-visibility OpenSpec change. Adds the
smallest social surface that lets us demo the product to logged-out
visitors without user signup.

Schema:
- `visibility text NOT NULL DEFAULT 'private'` on routes + activities.
- Shared Visibility type exported from the schema module.

Access:
- New canView(content, viewer, { asDirectLink }) helper in auth.server.ts
  centralises the rule: public → anyone; unlisted → anyone on direct
  link; private → owner only.
- routes.$id and activities.$id loaders return 404 (not 403) when
  canView rejects, so existence of private content isn't leaked.
- Detail pages emit Open Graph + Twitter Card meta on public/unlisted
  content only.

Editing:
- Visibility <select> on routes/:id/edit with owner-only access.
- Activity detail page gets a small visibility form + set-visibility
  action intent (no separate activity-edit page needed).
- EN + DE i18n under routes.visibility.* and activities.visibility.*.

Listings:
- Listing helpers listPublicRoutesForOwner / listPublicActivitiesForOwner
  for cross-user queries. Existing owner-scoped listRoutes/listActivities
  stay — owners see their own content regardless of visibility.

Public profile:
- /users/:username is now truly public. Renders the user's public
  routes + activities, 404s when no public content exists AND viewer
  isn't the owner (prevents account enumeration).
- Owner sees a short "this is your profile" note linking to settings.
- Open Graph meta (og:type=profile) for shareable preview.

Privacy manifest:
- Added a bullet noting public content is world-visible on profile
  and indexable by search engines.
- Bumped PRIVACY_LAST_UPDATED to 2026-04-20 + rendered legal-archive
  snapshot.

Tests:
- 13 unit tests for canView covering the full matrix.
- 6 E2E tests in e2e/public-content.test.ts covering:
  - Private route → 404 for logged-out visitor
  - Public route → reachable + OG tags present (og:title, og:type,
    og:site_name)
  - Owner still sees own private content
  - Profile 404 when no public content
  - Profile renders when at least one public route exists
  - Unlisted route reachable via direct URL but hidden from profile
- Test file runs serially (describe.configure mode=serial) to avoid
  WebAuthn virtual-authenticator races under Playwright's default
  parallel workers.
- New public-content Playwright project added to config.

Rollout safety: every existing row in prod keeps visibility='private'
by default — nothing becomes visible to outsiders until an owner
explicitly opts in.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 09:11:39 +02:00

485 lines
13 KiB
TypeScript

import { randomUUID, randomBytes } from "node:crypto";
import { eq, and, gt, isNull } from "drizzle-orm";
import {
generateRegistrationOptions,
verifyRegistrationResponse,
generateAuthenticationOptions,
verifyAuthenticationResponse,
} from "@simplewebauthn/server";
import type {
RegistrationResponseJSON,
AuthenticationResponseJSON,
AuthenticatorTransportFuture,
} from "@simplewebauthn/types";
import { getDb } from "./db.ts";
import { users, credentials, magicTokens } from "@trails-cool/db/schema/journal";
import type { Visibility } from "@trails-cool/db/schema/journal";
const RP_NAME = "trails.cool";
const RP_ID = process.env.DOMAIN ?? "localhost";
const ORIGIN = process.env.ORIGIN ?? `http://localhost:3000`;
// --- Registration ---
export async function startRegistration(email: string, username: string) {
const db = getDb();
// Check for existing email/username
const [existingEmail] = await db.select().from(users).where(eq(users.email, email));
if (existingEmail) throw new Error("Email already in use");
const [existingUsername] = await db.select().from(users).where(eq(users.username, username));
if (existingUsername) throw new Error("Username already taken");
const userId = randomUUID();
const options = await generateRegistrationOptions({
rpName: RP_NAME,
rpID: RP_ID,
userID: new TextEncoder().encode(userId),
userName: username,
userDisplayName: username,
attestationType: "none",
authenticatorSelection: {
residentKey: "preferred",
userVerification: "preferred",
},
});
return { options, userId };
}
export async function finishRegistration(
userId: string,
email: string,
username: string,
response: RegistrationResponseJSON,
challenge: string,
termsVersion: string,
) {
const db = getDb();
const verification = await verifyRegistrationResponse({
response,
expectedChallenge: challenge,
expectedOrigin: ORIGIN,
expectedRPID: RP_ID,
});
if (!verification.verified || !verification.registrationInfo) {
throw new Error("Registration verification failed");
}
const { credential } = verification.registrationInfo;
const domain = process.env.DOMAIN ?? "localhost";
// Create user and credential in a transaction
await db.insert(users).values({
id: userId,
email,
username,
domain,
termsAcceptedAt: new Date(),
termsVersion,
});
await db.insert(credentials).values({
id: randomUUID(),
userId,
credentialId: Buffer.from(credential.id, "base64url"),
publicKey: Buffer.from(credential.publicKey),
counter: credential.counter,
transports: response.response.transports,
});
return userId;
}
// --- Add Passkey to Existing Account ---
export async function addPasskeyStart(userId: string) {
const db = getDb();
const [user] = await db.select().from(users).where(eq(users.id, userId));
if (!user) throw new Error("User not found");
const options = await generateRegistrationOptions({
rpName: RP_NAME,
rpID: RP_ID,
userID: new TextEncoder().encode(userId),
userName: user.username,
userDisplayName: user.displayName ?? user.username,
attestationType: "none",
authenticatorSelection: {
residentKey: "preferred",
userVerification: "preferred",
},
});
return options;
}
export async function addPasskeyFinish(
userId: string,
response: RegistrationResponseJSON,
challenge: string,
) {
const db = getDb();
const verification = await verifyRegistrationResponse({
response,
expectedChallenge: challenge,
expectedOrigin: ORIGIN,
expectedRPID: RP_ID,
});
if (!verification.verified || !verification.registrationInfo) {
throw new Error("Passkey verification failed");
}
const { credential } = verification.registrationInfo;
await db.insert(credentials).values({
id: randomUUID(),
userId,
credentialId: Buffer.from(credential.id, "base64url"),
publicKey: Buffer.from(credential.publicKey),
counter: credential.counter,
transports: response.response.transports,
});
}
// --- Registration via Magic Link (no passkey) ---
export async function registerWithMagicLink(
email: string,
username: string,
termsVersion: string,
): Promise<string> {
const db = getDb();
const [existingEmail] = await db.select().from(users).where(eq(users.email, email));
if (existingEmail) throw new Error("Email already in use");
const [existingUsername] = await db.select().from(users).where(eq(users.username, username));
if (existingUsername) throw new Error("Username already taken");
const userId = randomUUID();
const domain = process.env.DOMAIN ?? "localhost";
await db.insert(users).values({
id: userId,
email,
username,
domain,
termsAcceptedAt: new Date(),
termsVersion,
});
// Create magic token for verification
const token = randomBytes(32).toString("base64url");
const expiresAt = new Date(Date.now() + 15 * 60 * 1000);
await db.insert(magicTokens).values({
id: randomUUID(),
email,
token,
expiresAt,
});
return token;
}
// --- Passkey Login ---
export async function startAuthentication() {
const options = await generateAuthenticationOptions({
rpID: RP_ID,
userVerification: "preferred",
});
return options;
}
export async function finishAuthentication(
response: AuthenticationResponseJSON,
challenge: string,
) {
const db = getDb();
const credentialIdBuffer = Buffer.from(response.rawId, "base64url");
// Find the credential
const [cred] = await db
.select()
.from(credentials)
.where(eq(credentials.credentialId, credentialIdBuffer));
if (!cred) throw new Error("Credential not found");
const verification = await verifyAuthenticationResponse({
response,
expectedChallenge: challenge,
expectedOrigin: ORIGIN,
expectedRPID: RP_ID,
credential: {
id: Buffer.from(cred.credentialId).toString("base64url"),
publicKey: new Uint8Array(cred.publicKey),
counter: cred.counter,
transports: cred.transports as AuthenticatorTransportFuture[] | undefined,
},
});
if (!verification.verified) {
throw new Error("Authentication verification failed");
}
// Update counter
await db
.update(credentials)
.set({ counter: verification.authenticationInfo.newCounter })
.where(eq(credentials.id, cred.id));
return cred.userId;
}
// --- Magic Links ---
function generateLoginCode(): string {
// 6-digit numeric code, zero-padded
const num = randomBytes(3).readUIntBE(0, 3) % 1_000_000;
return String(num).padStart(6, "0");
}
export async function createMagicToken(email: string): Promise<{ token: string; code: string }> {
const db = getDb();
// Check user exists
const [user] = await db.select().from(users).where(eq(users.email, email));
if (!user) throw new Error("No account found for this email");
const token = randomBytes(32).toString("base64url");
const code = generateLoginCode();
const expiresAt = new Date(Date.now() + 15 * 60 * 1000); // 15 minutes
await db.insert(magicTokens).values({
id: randomUUID(),
email,
token,
code,
expiresAt,
});
return { token, code };
}
export async function verifyLoginCode(email: string, code: string): Promise<string> {
const db = getDb();
const [record] = await db
.select()
.from(magicTokens)
.where(
and(
eq(magicTokens.email, email),
eq(magicTokens.code, code),
eq(magicTokens.purpose, "login"),
gt(magicTokens.expiresAt, new Date()),
isNull(magicTokens.usedAt),
),
);
if (!record) throw new Error("Invalid or expired code");
await db
.update(magicTokens)
.set({ usedAt: new Date() })
.where(eq(magicTokens.id, record.id));
const [user] = await db.select().from(users).where(eq(users.email, record.email));
if (!user) throw new Error("User not found");
return user.id;
}
export async function initiateEmailChange(userId: string, newEmail: string): Promise<string> {
const db = getDb();
const [existing] = await db.select().from(users).where(eq(users.email, newEmail));
if (existing) throw new Error("Email already in use");
const [user] = await db.select().from(users).where(eq(users.id, userId));
if (!user) throw new Error("User not found");
if (user.email === newEmail) throw new Error("This is already your email");
const token = randomBytes(32).toString("base64url");
const expiresAt = new Date(Date.now() + 15 * 60 * 1000);
await db.insert(magicTokens).values({
id: randomUUID(),
email: newEmail,
purpose: "email-change",
token,
expiresAt,
});
return token;
}
export async function verifyMagicToken(token: string): Promise<string> {
const db = getDb();
const [record] = await db
.select()
.from(magicTokens)
.where(
and(
eq(magicTokens.token, token),
eq(magicTokens.purpose, "login"),
gt(magicTokens.expiresAt, new Date()),
isNull(magicTokens.usedAt),
),
);
if (!record) throw new Error("Invalid or expired magic link");
await db
.update(magicTokens)
.set({ usedAt: new Date() })
.where(eq(magicTokens.id, record.id));
const [user] = await db.select().from(users).where(eq(users.email, record.email));
if (!user) throw new Error("User not found");
return user.id;
}
export async function verifyEmailChange(token: string, userId: string): Promise<string> {
const db = getDb();
const [record] = await db
.select()
.from(magicTokens)
.where(
and(
eq(magicTokens.token, token),
eq(magicTokens.purpose, "email-change"),
gt(magicTokens.expiresAt, new Date()),
isNull(magicTokens.usedAt),
),
);
if (!record) throw new Error("Invalid or expired verification link");
const newEmail = record.email;
// Re-check email availability at verification time — someone may have
// registered with this email between initiation and verification
const [existing] = await db.select().from(users).where(eq(users.email, newEmail));
if (existing) {
await db.update(magicTokens).set({ usedAt: new Date() }).where(eq(magicTokens.id, record.id));
throw new Error("This email is now in use by another account");
}
await db
.update(magicTokens)
.set({ usedAt: new Date() })
.where(eq(magicTokens.id, record.id));
await db
.update(users)
.set({ email: newEmail })
.where(eq(users.id, userId));
return newEmail;
}
// --- Sessions ---
import { createCookieSessionStorage } from "react-router";
const sessionSecret = process.env.SESSION_SECRET ?? "dev-secret-change-in-production";
export const sessionStorage = createCookieSessionStorage({
cookie: {
name: "__session",
httpOnly: true,
secure: process.env.NODE_ENV === "production",
sameSite: "lax",
path: "/",
maxAge: 60 * 60 * 24 * 30, // 30 days
secrets: [sessionSecret],
},
});
/**
* A row that carries the minimum a visibility check needs.
*/
export interface Viewable {
ownerId: string;
visibility: Visibility;
}
/**
* The caller's identity. `null` represents a logged-out visitor.
*/
export interface Viewer {
id: string;
}
/**
* Decide whether a viewer may see a piece of content.
*
* - `public` content is viewable by anyone.
* - `unlisted` content is viewable only on direct-link access — listings
* should omit it. Callers rendering a detail page pass `asDirectLink:
* true`; listings default to `false`.
* - `private` content is viewable only by the owner.
*
* Centralised here so detail loaders and listing queries use the same
* rule. Intentionally does not throw; callers handle the `false` case
* (usually by returning HTTP 404 rather than 403 to avoid leaking
* existence).
*/
export function canView(
content: Viewable,
viewer: Viewer | null,
{ asDirectLink = false }: { asDirectLink?: boolean } = {},
): boolean {
if (content.visibility === "public") return true;
if (content.visibility === "unlisted" && asDirectLink) return true;
return viewer?.id === content.ownerId;
}
/**
* Record the user's acceptance of the current Terms version. Updates both
* `terms_accepted_at` (NOW) and `terms_version`. Used when an existing user
* re-accepts after the Terms have been updated.
*/
export async function recordTermsAcceptance(userId: string, termsVersion: string) {
const db = getDb();
await db
.update(users)
.set({ termsAcceptedAt: new Date(), termsVersion })
.where(eq(users.id, userId));
}
export async function createSession(userId: string, request: Request) {
const session = await sessionStorage.getSession(request.headers.get("Cookie"));
session.set("userId", userId);
return sessionStorage.commitSession(session);
}
export async function getSessionUser(request: Request) {
const db = getDb();
const session = await sessionStorage.getSession(request.headers.get("Cookie"));
const userId = session.get("userId");
if (!userId) return null;
const [user] = await db.select().from(users).where(eq(users.id, userId));
return user ?? null;
}
export async function destroySession(request: Request) {
const session = await sessionStorage.getSession(request.headers.get("Cookie"));
return sessionStorage.destroySession(session);
}