trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix E2E: associate labels with inputs via htmlFor/id; increase test timeouts

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Ullrich Schäfer 2026-05-23 10:49:18 +02:00
parent 9959ce90e6
commit 25f7d35e03
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
apps/journal/app/routes/settings.connections.komoot.tsx
View file

@ -119,10 +119,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
</div>
<form onSubmit={handleVerify} className="mt-4 flex flex-col gap-3 sm:flex-row sm:items-end">
<div className="flex-1">
<label className="block text-sm font-medium text-gray-700">
<label htmlFor="komoot-profile-url" className="block text-sm font-medium text-gray-700">
{t("komoot.profileUrlLabel")}
</label>
<input
id="komoot-profile-url"
type="text"
value={komootProfileUrl}
onChange={(e) => setKomootProfileUrl(e.target.value)}
@ -158,10 +159,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
<h3 className="font-medium text-gray-900">{t("komoot.authenticatedSection")}</h3>
<form onSubmit={handleConnect} className="mt-4 flex flex-col gap-3">
<div>
<label className="block text-sm font-medium text-gray-700">
<label htmlFor="komoot-email" className="block text-sm font-medium text-gray-700">
{t("komoot.emailLabel")}
</label>
<input
id="komoot-email"
type="email"
value={email}
onChange={(e) => setEmail(e.target.value)}
@ -171,10 +173,11 @@ export default function KomootConnectPage({ loaderData }: Route.ComponentProps)
/>
</div>
<div>
<label className="block text-sm font-medium text-gray-700">
<label htmlFor="komoot-password" className="block text-sm font-medium text-gray-700">
{t("komoot.passwordLabel")}
</label>
<input
id="komoot-password"
type="password"
value={password}
onChange={(e) => setPassword(e.target.value)}

4
e2e/komoot-import.test.ts
View file

@ -123,6 +123,8 @@ function mockKomootGpx(page: Page, tourId: string) {
}
test.describe("Komoot connection page", () => {
test.setTimeout(60000);
test("unauthenticated user is redirected to login", async ({ page }) => {
await page.goto("/settings/connections/komoot");
await expect(page).toHaveURL(/\/auth\/login/, { timeout: 5000 });
@ -207,6 +209,8 @@ test.describe("Komoot connection page", () => {
});
test.describe("Komoot import page", () => {
test.setTimeout(90000);
test("shows importable public tours after public verify", async ({ page }) => {
const cdp = await page.context().newCDPSession(page);
const authenticatorId = await setupVirtualAuthenticator(cdp);