trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove broken data URI images from job summary

Browse source
This commit is contained in:
Ullrich Schäfer 2026-05-10 21:53:17 +02:00
parent e662212dca
commit e059f36db9
No known key found for this signature in database
GPG key ID: A32FF691A0F752D9
1 changed files with 2 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

24
.github/workflows/ci.yml vendored
View file

@ -144,26 +144,6 @@ jobs:
id: visual-tests id: visual-tests
run: pnpm --filter @trails-cool/planner test:visual run: pnpm --filter @trails-cool/planner test:visual
- name: Write diff images to job summary
if: failure() && steps.visual-tests.outcome == 'failure'
run: |
diffs=$(find apps/planner/.vitest-attachments -name "*-diff-*.png" 2>/dev/null | sort)
if [ -z "$diffs" ]; then exit 0; fi
echo "## Visual regression failures" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
for diff in $diffs; do
name=$(basename "$diff" | sed 's/-diff-chromium-[a-z]*\.png//' | sed 's/-/ /g')
b64=$(base64 -w 0 "$diff")
echo "### \`$name\`" >> $GITHUB_STEP_SUMMARY
echo "<img src=\"data:image/png;base64,$b64\" alt=\"$name diff\" style=\"max-width:100%\">" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
done
echo "To update snapshots if the change is intentional:" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "pnpm --filter @trails-cool/planner test:visual:update" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
- name: Post diff comment on PR - name: Post diff comment on PR
if: failure() && steps.visual-tests.outcome == 'failure' && github.event_name == 'pull_request' if: failure() && steps.visual-tests.outcome == 'failure' && github.event_name == 'pull_request'
env: env:
@ -172,14 +152,14 @@ jobs:
diffs=$(find apps/planner/.vitest-attachments -name "*-diff-*.png" 2>/dev/null | sort) diffs=$(find apps/planner/.vitest-attachments -name "*-diff-*.png" 2>/dev/null | sort)
if [ -z "$diffs" ]; then exit 0; fi if [ -z "$diffs" ]; then exit 0; fi
run_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" artifact_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
body="## Visual regression failures"$'\n\n' body="## Visual regression failures"$'\n\n'
body+="The following tests produced screenshot diffs:"$'\n\n' body+="The following tests produced screenshot diffs:"$'\n\n'
for diff in $diffs; do for diff in $diffs; do
name=$(basename "$diff" | sed 's/-diff-chromium-[a-z]*\.png//' | sed 's/-/ /g') name=$(basename "$diff" | sed 's/-diff-chromium-[a-z]*\.png//' | sed 's/-/ /g')
body+="- \`$name\`"$'\n' body+="- \`$name\`"$'\n'
done done
body+=$'\n'"**[View diff images in the job summary]($run_url)**"$'\n\n' body+=$'\n'"**[Download the \`visual-snapshots-diff\` artifact]($artifact_url)** to inspect the diffs locally."$'\n\n'
body+="To update snapshots if the change is intentional:"$'\n' body+="To update snapshots if the change is intentional:"$'\n'
body+="\`\`\`"$'\n' body+="\`\`\`"$'\n'
body+="pnpm --filter @trails-cool/planner test:visual:update"$'\n' body+="pnpm --filter @trails-cool/planner test:visual:update"$'\n'