fix(dev): seed the mobile OAuth client so dev sign-in works #149

Merged

ullrich merged 1 commit from seed-mobile-oauth-client into main 2026-09-12 07:33:41 +00:00

Conversation 0 Commits 1 Files changed 1 +15 -1

ullrich commented 2026-09-12 00:23:58 +00:00

Owner

Copy link

Signing in from the mobile app against a local journal fails:

{"error":"invalid_client","error_description":"Unknown client or redirect URI"}

journal.oauth_clients is empty on any fresh dev database.

Cause

seedOAuthClient("trails-cool-mobile", "trailscool://auth/callback", true) is called inside server.listen() in apps/journal/server.ts:102. But journal's scripts are:

"dev":   "react-router dev",                      // Vite — server.ts never loads
"start": "node --experimental-strip-types server.ts"

So the client is registered in production only. Mobile sign-in has never been able to work in dev without someone inserting the row by hand.

Fix

Seed it in scripts/seed.ts, which both pnpm dev:full and pnpm dev:reset run. The insert is onConflictDoNothing, so it's idempotent and leaves the production path in server.ts as the source of truth for deployed instances.

Verification

Against a local stack, with the row deleted to simulate a fresh DB:

Request	Before	After pnpm db:seed
/oauth/authorize?client_id=trails-cool-mobile&…	400 invalid_client	302 → /auth/login?returnTo=…
/oauth/authorize?client_id=bogus&…	400 invalid_client	400 invalid_client (still rejected)

End-to-end: sign-in from the Android emulator completes and lands on the Map tab.

pnpm typecheck 14/14, pnpm test 12/12, pnpm lint 14/14.

🤖 Generated with Claude Code

Signing in from the mobile app against a local journal fails: ```json {"error":"invalid_client","error_description":"Unknown client or redirect URI"} ``` `journal.oauth_clients` is empty on any fresh dev database. ### Cause `seedOAuthClient("trails-cool-mobile", "trailscool://auth/callback", true)` is called inside `server.listen()` in `apps/journal/server.ts:102`. But journal's scripts are: ```json "dev": "react-router dev", // Vite — server.ts never loads "start": "node --experimental-strip-types server.ts" ``` So the client is registered **in production only**. Mobile sign-in has never been able to work in dev without someone inserting the row by hand. ### Fix Seed it in `scripts/seed.ts`, which both `pnpm dev:full` and `pnpm dev:reset` run. The insert is `onConflictDoNothing`, so it's idempotent and leaves the production path in `server.ts` as the source of truth for deployed instances. ### Verification Against a local stack, with the row deleted to simulate a fresh DB: | Request | Before | After `pnpm db:seed` | |---|---|---| | `/oauth/authorize?client_id=trails-cool-mobile&…` | `400 invalid_client` | `302 → /auth/login?returnTo=…` | | `/oauth/authorize?client_id=bogus&…` | `400 invalid_client` | `400 invalid_client` (still rejected) | End-to-end: sign-in from the Android emulator completes and lands on the Map tab. `pnpm typecheck` 14/14, `pnpm test` 12/12, `pnpm lint` 14/14. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ullrich added 1 commit 2026-09-12 00:23:59 +00:00

fix(dev): seed the mobile OAuth client so dev sign-in works ... 21bc174d80

Signing in from the mobile app against a local journal failed with:

    {"error":"invalid_client",
     "error_description":"Unknown client or redirect URI"}

journal.oauth_clients was empty. seedOAuthClient("trails-cool-mobile",
…) is called inside server.listen() in apps/journal/server.ts, but that
file only runs under `pnpm start`; dev uses `react-router dev`. So the
client is registered in production and never in dev, and mobile sign-in
could not work on any fresh dev database.

Seeding it in scripts/seed.ts fixes it for every dev environment, since
both `pnpm dev:full` and `pnpm dev:reset` run that script. The insert is
onConflictDoNothing, so it stays idempotent alongside the production
path, which remains the source of truth for deployed instances.

Verified against a local stack: with the row absent, /oauth/authorize
returns 400 invalid_client; after `pnpm db:seed` the same request
returns 302 to /auth/login with the correct returnTo, and an unknown
client_id is still rejected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

ullrich merged commit b25342eae9 into main 2026-09-12 07:33:41 +00:00

ullrich referenced this pull request from a commit 2026-09-12 07:33:49 +00:00

Merge pull request 'fix(dev): seed the mobile OAuth client so dev sign-in works' (#149) from seed-mobile-oauth-client into main

ullrich referenced this pull request 2026-09-12 15:34:38 +00:00

docs(openspec): reconcile mobile specs with what shipped #152

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

dependencies

Dependency updates raised by Renovate (renovate.json5 labels)

  

major

Major version bump — always needs human review, never auto-merged

  

security-pin

Touches a pnpm.overrides CVE remediation pin, not an ordinary dependency

No labels

dependencies

major

security-pin

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

trails-cool/trails!149

No description provided.