chore(deps): move duplicated dependencies to the pnpm catalog #257

Merged
ullrich merged 2 commits from i18next-catalog into main 2026-10-12 10:20:28 +00:00
Owner

Summary

i18next was on the Renovate dashboard (#12) twice: once in the "production (non-major)" group and once in "development". #251 declared it in the apps' dependencies, and the root package.json still had it in devDependencies. Renovate groups by dependency type, so one update became two PRs.

Six more packages had the same problem: react-i18next, i18next-browser-languagedetector, leaflet, react-leaflet, fit-file-parser and linkedom. All seven are now pnpm catalog entries, and every manifest that uses them references them with catalog:. Renovate then updates one version in one place, in the production group.

The root devDependencies for these packages are removed. Each user declares its own:

  • packages/i18n: i18next and react-i18next as devDependencies. They are peers there, and its tests and typecheck need them.
  • packages/fit: fit-file-parser (devDependency, for tests).
  • packages/gpx: linkedom.

The resolved versions do not change: i18next 26.4.3, react-i18next 17.0.16, i18next-browser-languagedetector 8.2.1, leaflet 1.9.4, react-leaflet 5.0.0, fit-file-parser 6.2.2, linkedom 0.18.13.

Test plan

  • pnpm install --frozen-lockfile
  • pnpm typecheck, pnpm lint, pnpm test
  • scripts/check-dockerfiles.sh
  • CI: e2e and the journal image smoke test (the Docker build runs check-server-externals.mjs)

🤖 Generated with Claude Code

https://claude.ai/code/session_01LQv5c9rFGq2hSPpjLiFmQ8

## Summary `i18next` was on the Renovate dashboard (#12) twice: once in the "production (non-major)" group and once in "development". #251 declared it in the apps' `dependencies`, and the root `package.json` still had it in `devDependencies`. Renovate groups by dependency type, so one update became two PRs. Six more packages had the same problem: `react-i18next`, `i18next-browser-languagedetector`, `leaflet`, `react-leaflet`, `fit-file-parser` and `linkedom`. All seven are now pnpm catalog entries, and every manifest that uses them references them with `catalog:`. Renovate then updates one version in one place, in the production group. The root `devDependencies` for these packages are removed. Each user declares its own: - `packages/i18n`: `i18next` and `react-i18next` as devDependencies. They are peers there, and its tests and typecheck need them. - `packages/fit`: `fit-file-parser` (devDependency, for tests). - `packages/gpx`: `linkedom`. The resolved versions do not change: i18next 26.4.3, react-i18next 17.0.16, i18next-browser-languagedetector 8.2.1, leaflet 1.9.4, react-leaflet 5.0.0, fit-file-parser 6.2.2, linkedom 0.18.13. ## Test plan - [x] `pnpm install --frozen-lockfile` - [x] `pnpm typecheck`, `pnpm lint`, `pnpm test` - [x] `scripts/check-dockerfiles.sh` - [ ] CI: e2e and the journal image smoke test (the Docker build runs `check-server-externals.mjs`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LQv5c9rFGq2hSPpjLiFmQ8
chore(deps): move duplicated dependencies to the pnpm catalog
Some checks failed
CD Staging / Build & Push journal Image (pull_request) Has been skipped
CD Staging / Build & Push planner Image (pull_request) Has been skipped
CD Staging / Deploy Staging (pull_request) Has been skipped
CD Staging / Deploy PR Preview (pull_request) Has been skipped
CD Staging / Tear Down PR Preview (pull_request) Has been skipped
CI / Dockerfile Package Check (pull_request) Successful in 6s
CI / Security Scan (pull_request) Successful in 9s
CI / Visual Tests (pull_request) Successful in 42s
CI / Checks (pull_request) Failing after 4m26s
CI / E2E Tests (pull_request) Has been skipped
CI / Journal Image Smoke Test (pull_request) Successful in 4m39s
fdf9852999
i18next was listed twice on the Renovate dashboard (#12): once in the
"production (non-major)" group and once in "development". #251 declared
it in the apps' dependencies, and the root package.json still had it in
devDependencies. Renovate groups by dependency type, so one update became
two PRs.

The same applied to react-i18next, i18next-browser-languagedetector,
leaflet, react-leaflet, fit-file-parser and linkedom. These are now
catalog entries, referenced with `catalog:` from every manifest that uses
them, so Renovate updates one version in one place (catalog entries are in
the production group).

The root devDependencies for these packages are removed. Every user now
declares its own:
- packages/i18n: i18next and react-i18next as devDependencies (they are
  peers there, needed for its tests and typecheck)
- packages/fit: fit-file-parser (devDependency, tests)
- packages/gpx: linkedom

Resolved versions are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQv5c9rFGq2hSPpjLiFmQ8
fix(planner): declare linkedom, which @trails-cool/gpx needs at runtime
All checks were successful
CD Staging / Build & Push journal Image (pull_request) Has been skipped
CD Staging / Build & Push planner Image (pull_request) Has been skipped
CD Staging / Deploy Staging (pull_request) Has been skipped
CD Staging / Deploy PR Preview (pull_request) Has been skipped
CI / Dockerfile Package Check (pull_request) Successful in 5s
CI / Security Scan (pull_request) Successful in 10s
CI / Visual Tests (pull_request) Successful in 51s
CI / Journal Image Smoke Test (pull_request) Successful in 1m6s
CI / Checks (pull_request) Successful in 1m27s
CI / E2E Tests (pull_request) Successful in 3m59s
Cancel superseded CI / Cancel in-flight CI (pull_request) Successful in 2s
CD Staging / Tear Down PR Preview (pull_request) Successful in 14s
26fca7fc24
The planner build bundles @trails-cool/gpx (routes/new.tsx), and gpx
imports linkedom. Vite keeps a dependency external only when it resolves
from the app directory. The root devDependency removed in the previous
commit made that true by accident; without it, Vite tried to bundle
linkedom and its native canvas binding, and the build failed:

  [UNRESOLVED_IMPORT] Could not resolve '../build/Release/canvas.node'

Same rule as #251: an app declares the dependencies of every workspace
package it bundles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQv5c9rFGq2hSPpjLiFmQ8
ullrich scheduled this pull request to auto merge when all checks succeed 2026-10-12 10:15:02 +00:00
ullrich deleted branch i18next-catalog 2026-10-12 10:20:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
trails-cool/trails!257
No description provided.