fix(renovate): match pnpm-workspace.overrides in the override-pin rules #287

Merged
ullrich merged 1 commit from fix-renovate-override-deptype into main 2026-10-21 13:27:28 +00:00
Owner

Problem

The two renovate.json5 rules for override pins match matchDepTypes: ["pnpm.overrides"]:

  • one adds the security-pin label
  • one blocks minor and major updates (minor/major freeze)

pnpm 11 moved the overrides from package.json to overrides: in pnpm-workspace.yaml. Renovate reports those with depType pnpm-workspace.overrides (lib/modules/manager/npm/dep-types.ts, and CI runs renovate:latest). So since the move, neither rule matches anything:

  • #176: xmldom 0.8-line pin → 0.9.12. This broke expo prebuild (fixed in #277).
  • #272 / #273: undici 6.x and 7.x pins → 8.12.1 (major). Both merged and left a duplicate lockfile key (fixed in #276).
  • #283: the same xmldom change as #176, proposed again. It has automerge on, because Renovate counts 0.8→0.9 as a minor update.

None of them got the security-pin label.

Fix

Both rules now match ["pnpm.overrides", "pnpm-workspace.overrides"]. The old name stays, so a pin added back to package.json is still covered. I added a comment explaining why both depTypes are needed.

Verification

  • renovate.json5 parses with json5, and both rules show the new matcher.
  • renovate-config-validator was not run: npm could not reach the registry on this network.

Not in this PR

  • The undici 8.12.1 pins that #272/#273 already merged still need a manual review.
  • Close #283.

🤖 Generated with Claude Code

## Problem The two renovate.json5 rules for override pins match `matchDepTypes: ["pnpm.overrides"]`: - one adds the `security-pin` label - one blocks minor and major updates (minor/major freeze) pnpm 11 moved the overrides from `package.json` to `overrides:` in `pnpm-workspace.yaml`. Renovate reports those with depType **`pnpm-workspace.overrides`** (`lib/modules/manager/npm/dep-types.ts`, and CI runs `renovate:latest`). So since the move, neither rule matches anything: - #176: xmldom 0.8-line pin → 0.9.12. This broke `expo prebuild` (fixed in #277). - #272 / #273: undici 6.x and 7.x pins → 8.12.1 (major). Both merged and left a duplicate lockfile key (fixed in #276). - #283: the same xmldom change as #176, proposed again. It has automerge on, because Renovate counts 0.8→0.9 as a minor update. None of them got the `security-pin` label. ## Fix Both rules now match `["pnpm.overrides", "pnpm-workspace.overrides"]`. The old name stays, so a pin added back to `package.json` is still covered. I added a comment explaining why both depTypes are needed. ## Verification - `renovate.json5` parses with json5, and both rules show the new matcher. - `renovate-config-validator` was not run: npm could not reach the registry on this network. ## Not in this PR - The undici 8.12.1 pins that #272/#273 already merged still need a manual review. - Close #283. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(renovate): match pnpm-workspace.overrides in the override-pin rules
All checks were successful
CI / Dockerfile Package Check (pull_request) Successful in 5s
CI / Security Scan (pull_request) Successful in 8s
CI / Visual Tests (pull_request) Successful in 51s
CI / Checks (pull_request) Successful in 1m0s
CI / Journal Image Smoke Test (pull_request) Successful in 2m44s
CI / E2E Tests (pull_request) Successful in 3m14s
CD Staging / Build & Push journal Image (pull_request) Has been skipped
CD Staging / Build & Push planner Image (pull_request) Has been skipped
CD Staging / Deploy Staging (pull_request) Has been skipped
CD Staging / Deploy PR Preview (pull_request) Has been skipped
Cancel superseded CI / Cancel in-flight CI (pull_request) Successful in 4s
CD Staging / Tear Down PR Preview (pull_request) Successful in 16s
64ff5b6315
pnpm 11 moved overrides from package.json `pnpm.overrides` to
`overrides:` in pnpm-workspace.yaml, which Renovate reports as depType
`pnpm-workspace.overrides` (lib/modules/manager/npm/dep-types.ts). The
security-pin label and the minor/major freeze matched only the old name,
so both were dead: #176, #272, #273 and #283 crossed version lines
unlabelled and eligible for automerge, and #176 (xmldom 0.8 -> 0.9.12)
broke `expo prebuild` (fixed in #277).

Match both depTypes; keep the old one so a pin re-added to package.json
stays covered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ullrich scheduled this pull request to auto merge when all checks succeed 2026-10-21 13:24:55 +00:00
ullrich deleted branch fix-renovate-override-deptype 2026-10-21 13:27:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
trails-cool/trails!287
No description provided.