fix(brouter): drop the release's unused lib/ jars from the image #292

Merged
ullrich merged 1 commit from brouter-drop-lib into main 2026-10-29 11:42:14 +00:00
Owner

This finishes #290. The BRouter 1.7.10 release zip ships protobuf-java a second time, as a loose jar: lib/protobuf-java-3.12.2.jar, next to lib/osmosis-osm-binary-0.48.3.jar. Run 3089 of the dependency audit now reports it from that path. RouteServer runs with -cp brouter.jar, so lib/, brouter-*-ro.jar and BRouterApp.*.apk are never loaded. This PR deletes them in the same layer that unpacks the zip.

I couldn't build the image locally (no Docker daemon). CI's e2e job builds docker/brouter and routes against it.

Refs #168

🤖 Generated with Claude Code

This finishes #290. The BRouter 1.7.10 release zip ships `protobuf-java` a second time, as a loose jar: `lib/protobuf-java-3.12.2.jar`, next to `lib/osmosis-osm-binary-0.48.3.jar`. Run 3089 of the dependency audit now reports it from that path. `RouteServer` runs with `-cp brouter.jar`, so `lib/`, `brouter-*-ro.jar` and `BRouterApp.*.apk` are never loaded. This PR deletes them in the same layer that unpacks the zip. I couldn't build the image locally (no Docker daemon). CI's e2e job builds `docker/brouter` and routes against it. Refs #168 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(brouter): drop the release's unused lib/ jars from the image
All checks were successful
CI / Dockerfile Package Check (pull_request) Successful in 4s
CI / Security Scan (pull_request) Successful in 6s
CI / Visual Tests (pull_request) Successful in 40s
CI / Checks (pull_request) Successful in 48s
CI / Journal Image Smoke Test (pull_request) Successful in 56s
CI / E2E Tests (pull_request) Successful in 4m39s
CD Staging / Build & Push journal Image (pull_request) Has been skipped
CD Staging / Build & Push planner Image (pull_request) Has been skipped
CD Staging / Deploy Staging (pull_request) Has been skipped
CD Staging / Deploy PR Preview (pull_request) Has been skipped
Cancel superseded CI / Cancel in-flight CI (pull_request) Successful in 4s
CD Staging / Tear Down PR Preview (pull_request) Successful in 15s
2b1924b8a9
#290 stripped protobuf-java out of brouter.jar, but the release zip also
ships it loose as lib/protobuf-java-3.12.2.jar, and the dependency audit
now reports that copy. RouteServer runs with -cp brouter.jar, so lib/,
the -ro.jar and the Android APK are never loaded. Remove them.

Refs #168

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ullrich deleted branch brouter-drop-lib 2026-10-29 11:42:14 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
trails-cool/trails!292
No description provided.