fix(journal): type notifications summary() with TFunction #334
No reviewers
Labels
No labels
dependencies
major
security-pin
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
trails-cool/trails!334
Loading…
Reference in a new issue
No description provided.
Delete branch "fix-notifications-tfunction"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
summary()inapps/journal/app/routes/notifications.tsxdeclared itstparameter as a hand-written(key: string, opts?: Record<string, unknown>) => string. It now usesTFunction<"journal">fromi18next, the same approach asapps/planner/app/components/SessionView.tsx.Why
i18next 27 tightened
TFunction, so thetfromuseTranslation("journal")is no longer assignable to the hand-written signature. This is the TS2345 that failsCI / Checkson #331. Landing it first lets the grouped i18next Renovate PR (see #333) go green.Type-only change, no runtime behaviour change.
Testing
pnpm typecheck,pnpm lint,pnpm testpass onmain(i18next 26).renovate/i18next-27.x(i18next 27.1.2).🤖 Generated with Claude Code