ci: stop skipping CI on regenerated visual snapshots #343
No reviewers
Labels
No labels
dependencies
major
security-pin
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
trails-cool/trails!343
Loading…
Reference in a new issue
No description provided.
Delete branch "snapshots-drop-skip-ci"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
update-visual-snapshots.ymlcommitted the regenerated baselines with[skip ci]in the message. On Forgejo this leaves the branch head with noCI / *checks at all, so a PR that just had its baselines regenerated cannot merge until someone pushes again. #320 hit this: the snapshot commit had zero status contexts, and CI only ran after the branch was updated by merge.The marker has no documented reason. It was added with the original GitHub workflow in
34529a9and ported unchanged in08176ce; neither commit message nor any comment explains it. On GitHub it had little effect, because a push made with the default token does not trigger workflows there anyway.This PR removes the marker and adds a comment that says why.
Verification
prettier --checkpasses on the workflow file.ci.ymlon this Forgejo instance. If it does not, the behaviour is the same as today (no checks on the snapshot commit) and nothing gets worse. The next snapshot update will show which.pnpm typecheck,lint,test,test:e2e. The change is one commit message inside a dispatch-only workflow.Risk and rollback
ci.ymldoes not dispatch this workflow.🤖 Generated with Claude Code