ci: stop skipping CI on regenerated visual snapshots #343

Merged
ullrich merged 1 commit from snapshots-drop-skip-ci into main 2026-11-15 23:34:00 +00:00
Owner

Summary

update-visual-snapshots.yml committed the regenerated baselines with [skip ci] in the message. On Forgejo this leaves the branch head with no CI / * checks at all, so a PR that just had its baselines regenerated cannot merge until someone pushes again. #320 hit this: the snapshot commit had zero status contexts, and CI only ran after the branch was updated by merge.

The marker has no documented reason. It was added with the original GitHub workflow in 34529a9 and ported unchanged in 08176ce; neither commit message nor any comment explains it. On GitHub it had little effect, because a push made with the default token does not trigger workflows there anyway.

This PR removes the marker and adds a comment that says why.

Verification

  • prettier --check passes on the workflow file.
  • Not verified: that a push made by the workflow's job token triggers ci.yml on this Forgejo instance. If it does not, the behaviour is the same as today (no checks on the snapshot commit) and nothing gets worse. The next snapshot update will show which.
  • Not run locally: pnpm typecheck, lint, test, test:e2e. The change is one commit message inside a dispatch-only workflow.

Risk and rollback

  • Each snapshot update now costs one extra CI run on the target branch. That run is the one the PR needs.
  • No loop risk: ci.yml does not dispatch this workflow.
  • Revert the commit to roll back.

🤖 Generated with Claude Code

## Summary `update-visual-snapshots.yml` committed the regenerated baselines with `[skip ci]` in the message. On Forgejo this leaves the branch head with no `CI / *` checks at all, so a PR that just had its baselines regenerated cannot merge until someone pushes again. #320 hit this: the snapshot commit had zero status contexts, and CI only ran after the branch was updated by merge. The marker has no documented reason. It was added with the original GitHub workflow in 34529a9 and ported unchanged in 08176ce; neither commit message nor any comment explains it. On GitHub it had little effect, because a push made with the default token does not trigger workflows there anyway. This PR removes the marker and adds a comment that says why. ## Verification - `prettier --check` passes on the workflow file. - Not verified: that a push made by the workflow's job token triggers `ci.yml` on this Forgejo instance. If it does not, the behaviour is the same as today (no checks on the snapshot commit) and nothing gets worse. The next snapshot update will show which. - Not run locally: `pnpm typecheck`, `lint`, `test`, `test:e2e`. The change is one commit message inside a dispatch-only workflow. ## Risk and rollback - Each snapshot update now costs one extra CI run on the target branch. That run is the one the PR needs. - No loop risk: `ci.yml` does not dispatch this workflow. - Revert the commit to roll back. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
ci: stop skipping CI on regenerated visual snapshots
All checks were successful
Cancel superseded CI / Cancel in-flight CI (pull_request) Successful in 1s
948b8ee06d
The snapshot-update workflow committed with `[skip ci]`, so the branch
head it pushed had no `CI / *` checks and the PR could not merge until
someone pushed again (#320). The marker came from the original GitHub
workflow (34529a9) and was ported unchanged (08176ce); neither commit
gives a reason for it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ullrich deleted branch snapshots-drop-skip-ci 2026-11-15 23:34:00 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
trails-cool/trails!343
No description provided.