fix(deps): pin body-parser 2.4.0 and node-forge 1.4.3 #345

Merged
ullrich merged 1 commit from security-pin-body-parser-node-forge into main 2026-11-15 23:53:28 +00:00
Owner

Summary

Two security pins in pnpm-workspace.yaml overrides, for findings on the Vulnerability Dashboard (#168):

Package From → to Advisories Reachable from
body-parser 2.3.0 → 2.4.0 GHSA-27r3-jxmh-p828 (high, DoS via trailing bytes after a compressed body) both apps' servers: @react-router/serve>express>body-parser
node-forge 1.4.0 → 1.4.3 21 advisories (8 high) Expo tooling only: @expo/cli>@expo/code-signing-certificates

Both pins stay inside the range the consumer asks for (express@5.3.0 wants ^2.3.0, @expo/code-signing-certificates@0.0.7 wants ^1.4.0), so neither moves a consumer onto a different API line. The old "NOT PINNED: node-forge … no patched release exists" comment is replaced, because fixes shipped (1.4.1 on 2026-10-27, 1.4.3 on 2026-11-04).

Verification

  • Lockfile diff contains only body-parser and node-forge entries.
  • pnpm audit: 26 findings (9 high) before → 4 after (0 high): deepmerge, esbuild, glob, minimatch.
  • pnpm typecheck, pnpm lint, pnpm test: pass locally.
  • Not run locally: pnpm test:e2e. CI's E2E and Journal Image Smoke Test exercise express with the new body-parser.
  • Not checked: whether the apps accept compressed request bodies, i.e. how exposed the body-parser advisory was in practice.

Remaining on #168 after this

  • esbuild 0.18.20: deliberately not pinned, documented in pnpm-workspace.yaml.
  • glob, minimatch: the fixes are new majors (14.x, 11.x) that the jest and Sentry build tooling do not accept.
  • Photon's bundled Java libraries: fixed only by a new Photon release; 1.3.0 is the latest.

Risk and rollback

  • body-parser 2.4.0 is a minor release in the production request path; the risk is a behaviour change in body parsing. Revert the commit to roll back.
  • Merging touches pnpm-lock.yaml, so cd-apps.yml deploys journal and planner.

🤖 Generated with Claude Code

## Summary Two security pins in `pnpm-workspace.yaml` overrides, for findings on the Vulnerability Dashboard (#168): | Package | From → to | Advisories | Reachable from | |---|---|---|---| | `body-parser` | 2.3.0 → 2.4.0 | GHSA-27r3-jxmh-p828 (high, DoS via trailing bytes after a compressed body) | both apps' servers: `@react-router/serve>express>body-parser` | | `node-forge` | 1.4.0 → 1.4.3 | 21 advisories (8 high) | Expo tooling only: `@expo/cli>@expo/code-signing-certificates` | Both pins stay inside the range the consumer asks for (`express@5.3.0` wants `^2.3.0`, `@expo/code-signing-certificates@0.0.7` wants `^1.4.0`), so neither moves a consumer onto a different API line. The old "NOT PINNED: node-forge … no patched release exists" comment is replaced, because fixes shipped (1.4.1 on 2026-10-27, 1.4.3 on 2026-11-04). ## Verification - Lockfile diff contains only `body-parser` and `node-forge` entries. - `pnpm audit`: 26 findings (9 high) before → 4 after (0 high): `deepmerge`, `esbuild`, `glob`, `minimatch`. - `pnpm typecheck`, `pnpm lint`, `pnpm test`: pass locally. - Not run locally: `pnpm test:e2e`. CI's E2E and Journal Image Smoke Test exercise express with the new `body-parser`. - Not checked: whether the apps accept compressed request bodies, i.e. how exposed the `body-parser` advisory was in practice. ## Remaining on #168 after this - `esbuild` 0.18.20: deliberately not pinned, documented in `pnpm-workspace.yaml`. - `glob`, `minimatch`: the fixes are new majors (14.x, 11.x) that the jest and Sentry build tooling do not accept. - Photon's bundled Java libraries: fixed only by a new Photon release; 1.3.0 is the latest. ## Risk and rollback - `body-parser` 2.4.0 is a minor release in the production request path; the risk is a behaviour change in body parsing. Revert the commit to roll back. - Merging touches `pnpm-lock.yaml`, so `cd-apps.yml` deploys journal and planner. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(deps): pin body-parser 2.4.0 and node-forge 1.4.3
All checks were successful
CD Staging / Build & Push journal Image (pull_request) Has been skipped
CD Staging / Build & Push planner Image (pull_request) Has been skipped
CD Staging / Deploy Staging (pull_request) Has been skipped
CD Staging / Deploy PR Preview (pull_request) Has been skipped
CI / Security Scan (pull_request) Successful in 9s
CI / Dockerfile Package Check (pull_request) Successful in 5s
CI / Visual Tests (pull_request) Successful in 48s
CI / Checks (pull_request) Successful in 3m7s
CI / Journal Image Smoke Test (pull_request) Successful in 2m0s
CI / E2E Tests (pull_request) Successful in 3m19s
Cancel superseded CI / Cancel in-flight CI (pull_request) Successful in 2s
CD Staging / Tear Down PR Preview (pull_request) Successful in 13s
f33d7f94dc
body-parser 2.3.0 has GHSA-27r3-jxmh-p828 (high, DoS) and sits in the
request path of both apps via @react-router/serve>express. node-forge
1.4.0 has 21 advisories; it is reachable only from Expo tooling, and the
workspace file said to pin it once a fix shipped. Both pins stay inside
the range their consumers ask for (^2.3.0 and ^1.4.0).

`pnpm audit` goes from 26 findings to 4 (deepmerge, esbuild, glob,
minimatch).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ullrich scheduled this pull request to auto merge when all checks succeed 2026-11-15 23:42:40 +00:00
ullrich deleted branch security-pin-body-parser-node-forge 2026-11-15 23:53:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
trails-cool/trails!345
No description provided.