trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
trails/openspec/changes/gpx-parser-robustness/tasks.md
Ullrich Schäfer 5dd4968626 docs+openspec: prior-art research (Organic Maps, Endurain, wanderer) and 15 proposals 
Add docs/inspirations.md as the durable record of the 2026-07-05/06
prior-art research — per-project learnings with source paths, canonical
credit lines, and the changes each spawned — and extend the
acknowledgment lists in philosophy.md/architecture.md (Organic Maps,
Endurain, wanderer).

New OpenSpec changes (proposal/design/specs/tasks each):
- Organic Maps: elevation-profile-hardening, gpx-parser-robustness,
  hiking-time-estimate, poi-index, hiking-foot-profile
- Endurain: account-export, activity-duplicate-review,
  fit-parsing-hardening, activity-locations, self-hosting-guide,
  activity-privacy-controls
- wanderer: federation-hardening, link-share-tokens
- credits-page (user-visible acknowledgments)

Updated in-flight changes with wanderer prior-art sections:
route-federation, route-discovery.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-06 07:23:00 +02:00

2.5 KiB
Raw Blame History

1. Parser lenience

  • 1.1 Add a finite-number coordinate gate in packages/gpx/src/parse.ts: skip trkpt/rtept with missing or non-finite lat/lon; treat non-finite <ele> as undefined
  • 1.2 Drop segments with fewer than 2 surviving points
  • 1.3 Unit tests: missing-lat point skipped, garbage lat skipped with finite stats, garbage ele → undefined with finite gain/loss, single-point segment dropped, well-formed files byte-identical output to before

2. Route (<rte>) support

  • 2.1 Parse <rte>/rtept as track segments (appended after <trk> segments), reusing the same point parsing and lenience
  • 2.2 Unit tests: route-only file yields one segment and passes validateGpx; mixed trk+rte ordering; rtept with ele/time preserved

3. Timestamp repair

  • 3.1 Create packages/gpx/src/timestamp-repair.ts: per-segment pass — >50% invalid → drop all; else linear interpolation between valid neighbors with leading/trailing clamp; output ISO 8601 strings
  • 3.2 Wire the repair pass into parseTracks output in parse.ts
  • 3.3 Unit tests (timestamp-repair.test.ts): sparse invalid interpolated, >50% invalid dropped (and movingTime returns null), leading/trailing clamp, all-valid untouched, no-timestamps untouched

4. Metadata fallback

  • 4.1 Fall back to first <trk>/<rte> <name>/<desc> when <metadata> lacks them; merge distinct <cmt> into description with blank-line separator, dedup identical
  • 4.2 Unit tests: track-name fallback, metadata precedence, cmt merge, identical cmt deduped

5. Fixture corpus

  • 5.1 Create packages/gpx/fixtures/ with purpose-named files: route-only.gpx, missing-coords.gpx, garbage-ele.gpx, timestamps-partial.gpx, timestamps-mostly-invalid.gpx, multi-track.gpx, unicode-name.gpx, namespaced-extensions.gpx (Garmin/OsmAnd-style extensions)
  • 5.2 Add trimmed real-world exports for supported integrations (Komoot, Wahoo) with any personal data scrubbed
  • 5.3 Extend parse-node.test.ts to load every fixture from disk and assert expected repaired output (a fixture table test so new files are picked up automatically or fail loudly)

6. Verification

  • 6.1 Typecheck + run full gpx package suite; confirm GpxData shape unchanged and journal/planner compile without changes
  • 6.2 Manual check: import a route-only GPX and a partially-broken GPX through the journal import flow; confirm both save with sane stats
  • 6.3 Run pnpm typecheck && pnpm lint && pnpm test and the e2e suites