trails-cool/trails
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
trails/apps/journal/app/routes
History
Ullrich Schäfer 8eba5b2d9e
fix(journal): centralize session-auth helpers + extract .server.ts siblings 
Follow-up to PR #406 — addresses the two items deferred from the audit:

#7 — Centralize auth helpers
- New `requireSessionUser(request)` in lib/auth/session.server.ts that
  returns the user or throws a redirect to /auth/login.
- New `requireSessionUserJson(request)` companion that throws a 401 JSON
  response (for fetcher/JSON endpoints).
- Replace the repeated
    const user = await getSessionUser(request);
    if (!user) return redirect("/auth/login");
  pattern across 18 route loaders/actions. Removes the duplicated guard
  preamble and gives a single chokepoint to evolve later (e.g., for
  terms-version gating).

#8 — Extract heavy loaders into .server.ts siblings
- routes/home.tsx → home.server.ts (DB count query + listActivities +
  listRecentPublicActivities)
- routes/users.$username.tsx → users.$username.server.ts (user lookup +
  follow state + counts + listPublicRoutes/Activities + persona check)
- routes/settings.connections.tsx → settings.connections.server.ts
  (connected_services join + manifest merge)

Each route file shrinks to a thin delegator: `loader` calls
`loadXxx(request)`. The component module no longer transitively pulls
`getDb` and Drizzle schema into its import graph — Vite's tree-shake
already strips server-only code from the client bundle, but the
explicit `.server.ts` suffix makes that contract local and auditable.

Other 17 routes that mix loader/action with components are left as-is
for now: they're each small enough that the split adds churn without
buying much clarity. The pattern is documented by the three examples;
the rest can convert opportunistically when they grow.

Tests:
- lib/auth/session.server.test.ts (4 cases — redirect for missing
  cookie, redirect for ghost userId, success path, JSON 401 variant)

Full repo: pnpm typecheck, pnpm lint, pnpm test all green
(181 passed | 31 integration-gated skipped).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-24 10:44:33 +02:00
..
activities.$id.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
activities._index.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
activities.new.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.auth.login.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.auth.register.test.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.auth.register.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.e2e.komoot.ts Rewrite komoot E2E tests to use server-side seed endpoint 2026-05-23 10:57:16 +02:00
api.e2e.route.$id.ts Fix unused import lint error in api.e2e.route.$id.ts 2026-05-10 15:24:31 +02:00
api.e2e.seed.ts Show POI details (phone, website, opening hours) on Journal route detail page 2026-05-17 23:32:38 +02:00
api.events.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.follows.$id.approve.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.follows.$id.reject.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.metrics.ts Add observability: health endpoints, structured logging, metrics, Grafana stack 2026-03-26 22:59:44 +01:00
api.notifications.$id.read.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.notifications.read-all.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.routes.$id.callback.ts Atomic GPX save: validate + persist row + geometry in one transaction 2026-05-10 15:02:56 +02:00
api.routes.$id.edit-in-planner.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.routes.$id.gpx.ts Add route detail day segment highlighting and per-day GPX export 2026-04-11 00:44:11 +02:00
api.settings.delete-account.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.settings.email.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.settings.passkey.delete.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.settings.profile.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.sync.callback.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.connect.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.disconnect.$provider.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.connect.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.import-status.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.import.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.komoot.verify.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.push.$provider.$routeId.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
api.sync.webhook.$provider.test.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.sync.webhook.$provider.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
api.users.$username.follow.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.users.$username.unfollow.ts Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
api.v1.activities.$id.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.activities._index.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.auth.devices.$id.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.auth.devices.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
api.v1.routes.$id.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.routes._index.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.v1.routes.compute.ts Session-bind /api/route and /api/overpass 2026-04-21 22:18:45 +02:00
api.v1.routes.test.ts fix: enforce Terms gate on bearer-token API requests 2026-05-08 01:59:28 +02:00
api.v1.test.ts Add unit tests for REST API validation and pagination 2026-04-13 00:58:18 +02:00
api.v1.uploads.ts DRY up ZodError → FieldError mapping 2026-04-19 11:45:09 +02:00
api.well-known.trails-cool.test.ts Implement OAuth2 PKCE auth, discovery, and mobile API client 2026-04-13 00:41:40 +02:00
api.well-known.trails-cool.ts fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
auth.accept-terms.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
auth.login.tsx Implement completeAuth chokepoint + caller migration 2026-05-08 02:38:15 +02:00
auth.logout.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
auth.register.tsx Implement completeAuth chokepoint + caller migration 2026-05-08 02:38:15 +02:00
auth.verify.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
explore.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
feed.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
follows.requests.tsx Merge /follows/requests into /notifications as a tabbed inbox 2026-04-26 08:24:59 +02:00
home.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
home.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
legal.imprint.tsx Apply minimal legal-review follow-ups 2026-04-19 07:27:56 +02:00
legal.privacy.tsx Add Komoot import with public (bio verification) and authenticated modes 2026-05-23 10:18:46 +02:00
legal.terms.tsx Store Terms version alongside acceptance timestamp 2026-04-19 07:46:34 +02:00
notifications.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
oauth.authorize.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
oauth.token.ts Implement Journal REST API v1 endpoints 2026-04-13 00:57:27 +02:00
privacy.tsx Add legal pages, ToS acceptance, and alpha banner 2026-04-18 00:08:48 +02:00
routes.$id.edit.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
routes.$id.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
routes._index.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
routes.new.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
settings._index.tsx Split /settings into 4 sub-pages with a sidebar layout 2026-04-26 09:48:00 +02:00
settings.account.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
settings.connections.komoot.tsx fix(journal): architectural audit omnibus 2026-05-24 10:28:33 +02:00
settings.connections.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
settings.connections.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
settings.profile.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
settings.security.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
settings.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
sync.import.$provider.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
sync.import.komoot.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
users.$username.followers.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
users.$username.following.tsx Drop auth.server.ts re-exports + rename to .server.ts convention (task 5.2) 2026-05-08 03:01:30 +02:00
users.$username.server.ts fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00
users.$username.tsx fix(journal): centralize session-auth helpers + extract .server.ts siblings 2026-05-24 10:44:33 +02:00