990bbaa99e
Task group 1 of elevation-profile-hardening. New pure module
elevation-clean.ts (not yet wired — group 2 does that):
- despike(points): interpolates out isolated peak/pit spikes (opposite-sign
slope outliers both exceeding MAX_SLOPE_PERCENT=100); steep monotonic
terrain (same-sign) is never touched; per-segment, no cross-gap interp.
- filteredTotals(points): hysteresis ascent/descent (NOISE_THRESHOLD_M=5)
that suppresses sub-threshold jitter, returning {gain,loss,gainRaw,lossRaw}.
- cumulativeFilteredTotals(points): running filtered arrays for per-day
splits (day total = cumulative[end] − cumulative[start]).
DESIGN NOTE for review: the spec's task 1.2 says the zero-filtered
fallback should "report raw", but the raw sum-of-deltas re-inflates the
very jitter we remove (a ±2 m wobble sums to several metres) — directly
contradicting task 1.4's "±2 m jitter → 0 totals". Resolved toward the
stated goal: fall back to NET change (end−start), so flat wobble reads ~0
while a genuine small net climb still surfaces. gainRaw/lossRaw still
expose the raw sums.
Verified: gpx typecheck+lint clean, 108/108; full pnpm test 11/11.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2.1 KiB
2.1 KiB
1. Cleaning primitives
- 1.1 Create
packages/gpx/src/elevation-clean.tswithdespike(points, opts?)— opposite-sign slope-outlier detection (defaultMAX_SLOPE_PERCENT = 100) with linear interpolation, operating per segment on{ distance, elevation }sequences - 1.2 Add
filteredTotals(points, opts?)to the same module — hysteresis accumulator (defaultNOISE_THRESHOLD_M = 5) returning{ gain, loss, gainRaw, lossRaw }with the raw-fallback rule (filtered zero + raw non-zero → report raw) - 1.3 Add
cumulativeFilteredTotals(points, opts?)returning per-point running filtered ascent/descent arrays (for per-day splits) - 1.4 Write
elevation-clean.test.ts: isolated spike interpolated; steep monotonic climb untouched; no cross-segment interpolation; ±2 m jitter → 0 totals; multi-leg climb counted fully; near-flat raw fallback; cumulative arrays sum to totals
2. Wire into existing computations
- 2.1 Update
computeElevationinpackages/gpx/src/parse.tsto despike per segment, then usefilteredTotals; keepgain/loss/profileshape and exposegainRaw/lossRawas additional fields (profile built from despiked data) - 2.2 Update
elevationSeriesinpackages/gpx/src/elevation-series.tsto build from despiked points (despike per segment before flattening) - 2.3 Update
compute-days.tsto build its cumulative ascent/descent arrays viacumulativeFilteredTotalsover the despiked track - 2.4 Update/extend existing tests (
parse.test.ts,elevation-series.test.ts,compute-days.test.ts) with a shared noisy-track fixture; assert chart series, totals, and day sums agree
3. Verification
- 3.1 Confirm no consumer changes needed: typecheck journal + planner; spot-check
gpx-save.server.ts, detail loaders, and plannercomputeDaysusage compile and behave - 3.2 Manual sanity check: parse a real noisy activity GPX (e.g. an existing import fixture) and compare gain before/after — filtered value should drop noticeably and match the chart
- 3.3 Run
pnpm typecheck && pnpm lint && pnpm testand the journal/planner e2e suites