fix(brouter): strip unused protobuf-java from the server jar #290
No reviewers
Labels
No labels
dependencies
major
security-pin
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
trails-cool/trails!290
Loading…
Reference in a new issue
No description provided.
Delete branch "brouter-strip-protobuf"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
BRouter's
-all.jarbundlesprotobuf-java3.12.2 (GHSA-4gg5-vx3j-xwc7 and four more DoS advisories) together with the osmosis PBF reader that uses it. Both are there only forbrouter-map-creator, which builds.rd5segments from OSM extracts.RouteServernever loads them, because we download prebuilt segments. 1.7.10 is the latest release, so no version bump fixes this. This PR removescom/google/protobuf/*,google/protobuf/*.proto, the protobuf Maven metadata andorg/openstreetmap/osmosis/*from the jar at build time.Verified locally (Docker wasn't running, so I tested the jar directly with Java): I stripped the 1.7.10 jar the same way and ran
RouteServeragainstE10_N50.rd5. A trekking route across Berlin came back as valid GeoJSON (3.4 km), and the log showed no exceptions. CI's e2e job, which uses the real BRouter, covers the rest.This deploys through
cd-brouter.ymlon merge.Refs #168
🤖 Generated with Claude Code